Repository navigation
Show Ready for review merge conflicts and cached GitHub facts - #1672
Merged
Merged
Conversation
Preserve both the Console version description from main and the merge-conflict and cached-GitHub-facts descriptions from issue-1662.
This was referenced Oct 30, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Conflicting pull requests stay Ready for review. CI and mergeability remain independent.
showreads the cache even when stale and preserves frozen History observations without calling GitHub. The manual and hand-written site pages describe the indicators and JSON fields.Closes #1662
Test seams
Evidence
cargo test --test console mergeability_changes_wake_ready_rows_independently_of_ci -- --nocapturefailed because green-CI rows had no mergeability.cargo test --test status show_reads_cached_github_facts_without_refreshing -- --nocapturefailed becauseshowomitted the cached state.After: both regressions pass. The mergeability test exercises changes with unchanged green CI, Inbox stream updates, row placement, text/JSON status and cache reuse.
cargo test --test status cached_github -- --nocapture: 3 passed, covering stale answers without network access, old cache defaults, missing cache, issue facts and frozen observations.node --test --test-name-pattern='Ready rows show CI and merge conflicts' console/tests/inbox.test.cjs: passed across Focus/Signal light/dark at 1440, 768 and 390 px, with and without JavaScript, including live updates.npm run docs --prefix site,npm run docs:check --prefix site,cargo fmt --checkandcargo clippy --all-targets -- -D warnings: passed.scripts/affected-tests main: passed — 60 site tests, 126 Console browser tests, and 3,616 Rust tests passed (75 skipped).cargo nextest run: 2,924.69 s including compilation; test execution was 2,720.363 s. The complete affected-test selection took 3,301.09 s. Browser files ran serially (--test-concurrency=1), with 3 Rust test slots.Review coverage
Independent Standards and Spec reviews against
main, including one follow-up for the shared cached-facts projection. Standards: 1 design finding, addressed. Spec: 0 findings. Both axes read all 18 changed files, including generated manual hunks; no generated-output exclusions and no unread changed files.Merge Danger
Door: two-way
Blast Radius: Inbox
Adds an optional JSON field and a backward-compatible cached mergeability value; affects cached GitHub presentation in the Console,
statusandshow.Unaddressed findings
Standards
None. The duplicated projection finding was addressed in
202be3a7by sharingCommandAnswerandKept::command_answerbetween Inbox andshow.Spec
None.
Security
None.
Built with codex codex-cli 0.164.0 · gpt-6.1-sol · xhigh
Security review outcome
No unaddressed introduced findings.