Skip to content

Show the running thirdshift version in Console headers - #1657

Merged
JacobStephens2 merged 4 commits into
mainfrom
issue-1656
Oct 30, 2026
Merged

JacobStephens2 merged 4 commits into
mainfrom
issue-1656

Conversation

@JacobStephens2

@JacobStephens2 JacobStephens2 commented Oct 30, 2026 •

Copy link
Copy Markdown
Owner

Summary

Show the running binary's version in the shared Console brand on reader and account pages, including sign-in. The value comes from Cargo package metadata and follows release builds automatically.

- thirdshift / Console
+ thirdshift 0.18.7 / Console

Closes #1656

Evidence

  • On 8ed95427, RUST_TEST_THREADS=3 NEXTEST_TEST_THREADS=3 scripts/affected-tests origin/main passed: 60 site tests, 125 Console browser tests, the locked binary build and the full Rust suite. Rust validation took 2355.12s including compilation. The global artifact build also passed locally in 2.68s; installer shell syntax and both binary archive checksums passed.
  • Before: cargo test --test console console_pages_show_the_running_thirdshift_version -- --exact failed because Inbox did not show thirdshift 0.18.7 / Console.
    After: the same test passes on Inbox, Logs, Account and Console log, comparing the header with the running binary's --version output.
  • cargo check --locked and cargo fmt --check pass.
  • Chromium checks at 375px and 1440px confirm the version is visible on Inbox and Account with JavaScript disabled; screenshots inspected.
  • scripts/affected-tests main passed the site suite and build, then stopped on an existing live CI-badge update test's 5-second timeout. The exact case passes in isolation: node --test --test-name-pattern='^Ready rows show CI without clipping on desktop or phone and update live$' console/tests/inbox.test.cjs (1 passed, 3.23s). GitHub's complete console-test suite also passed on this same head.
  • The full Rust suite, formatting, clippy and macOS gate passed in CI for reviewed head 82fdd5f778349867fefa0fea4f72e17a64fe2bc9. Console and site CI also passed.
  • Supplemental local /usr/bin/time -p cargo test -- --test-threads=3: stopped after successful same-head CI, following the repository's CI reuse policy (exit 130; 1145.48s wall time, compilation included). The binary unit suite (1,621 passed, 3 ignored), full Console HTTP suite and completed integration suites passed; no Rust failures were observed before stopping.

Merge Danger

Door: two-way

Reverting restores the previous header text. No persistent data changes.

Blast Radius: Console

Reader and account header text, plus the public site's Console description.

Test seams

  • The Console's public HTTP pages and the running binary's --version output: reader and account pages display the same thirdshift version.

Review coverage

Independent thirdshift-code-review against main: Standards 0 findings; Spec 0 findings. Both axes read all five changed files. Generated-output exclusions: none. Unread changed files: none.

Unaddressed findings

  • Standards: none.
  • Spec: none.
  • Security: none.

Built with codex codex-cli 0.164.0 · gpt-6.1-sol · xhigh

Security review outcome

No unaddressed introduced findings.

CI notes

  • build-global-artifacts was cancelled by GitHub's five-minute job timeout after dist succeeded, all three artifacts uploaded, and the logs reached runner cleanup (job and annotation); the release workflow, generator and dist configuration are identical to main, and dist build --output-format=json --artifacts=global passes locally in 2.68s using this run's binary artifacts.

@JacobStephens2
JacobStephens2 merged commit 40c7063 into main Oct 30, 2026
21 checks passed
@JacobStephens2
JacobStephens2 deleted the issue-1656 branch October 30, 2026 19:02
@JacobStephens2 JacobStephens2 mentioned this pull request Oct 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

show thirdshift version in console web ui

1 participant