Repository navigation
Show the running thirdshift version in Console headers - #1657
Merged
Merged
Conversation
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Show the running binary's version in the shared Console brand on reader and account pages, including sign-in. The value comes from Cargo package metadata and follows release builds automatically.
Closes #1656
Evidence
8ed95427,RUST_TEST_THREADS=3 NEXTEST_TEST_THREADS=3 scripts/affected-tests origin/mainpassed: 60 site tests, 125 Console browser tests, the locked binary build and the full Rust suite. Rust validation took 2355.12s including compilation. The global artifact build also passed locally in 2.68s; installer shell syntax and both binary archive checksums passed.cargo test --test console console_pages_show_the_running_thirdshift_version -- --exactfailed because Inbox did not showthirdshift 0.18.7 / Console.After: the same test passes on Inbox, Logs, Account and Console log, comparing the header with the running binary's
--versionoutput.cargo check --lockedandcargo fmt --checkpass.scripts/affected-tests mainpassed the site suite and build, then stopped on an existing live CI-badge update test's 5-second timeout. The exact case passes in isolation:node --test --test-name-pattern='^Ready rows show CI without clipping on desktop or phone and update live$' console/tests/inbox.test.cjs(1 passed, 3.23s). GitHub's completeconsole-testsuite also passed on this same head.82fdd5f778349867fefa0fea4f72e17a64fe2bc9. Console and site CI also passed./usr/bin/time -p cargo test -- --test-threads=3: stopped after successful same-head CI, following the repository's CI reuse policy (exit 130; 1145.48s wall time, compilation included). The binary unit suite (1,621 passed, 3 ignored), full Console HTTP suite and completed integration suites passed; no Rust failures were observed before stopping.Merge Danger
Door: two-way
Reverting restores the previous header text. No persistent data changes.
Blast Radius: Console
Reader and account header text, plus the public site's Console description.
Test seams
--versionoutput: reader and account pages display the same thirdshift version.Review coverage
Independent
thirdshift-code-reviewagainstmain: Standards 0 findings; Spec 0 findings. Both axes read all five changed files. Generated-output exclusions: none. Unread changed files: none.Unaddressed findings
Built with codex codex-cli 0.164.0 · gpt-6.1-sol · xhigh
Security review outcome
No unaddressed introduced findings.
CI notes
build-global-artifactswas cancelled by GitHub's five-minute job timeout afterdistsucceeded, all three artifacts uploaded, and the logs reached runner cleanup (job and annotation); the release workflow, generator and dist configuration are identical tomain, anddist build --output-format=json --artifacts=globalpasses locally in 2.68s using this run's binary artifacts.