Repository navigation
Show pull request CI on Ready for review rows - #1650
Merged
Merged
Conversation
This was referenced Oct 30, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ready for review rows show the connected pull request's latest head CI, refreshed by the existing batched GitHub read. Pending, no checks and unknown answers have their own labels; old cache entries default to unknown. Console and
statusshare the saved answer.Closes #1649
Evidence
cargo test --test console ready_rows_show_current_ci_and_status_reuses_it -- --exact github::ready_rows_show_current_ci_and_status_reuses_itfailed waiting for a CI-only Inbox update.After: passes, covering SUCCESS/FAILURE/ERROR/PENDING/EXPECTED, no checks, unknown answers, live updates and CLI reuse.
node --test --test-name-pattern='Ready rows show CI' console/tests/inbox.test.cjsfailed with768: CI green must be readable.After: the retained regression passes at 1440, 768 and 390 px in light/dark Focus and Signal Themes, including live changes, old/unread caches and a page with JavaScript disabled.
/usr/bin/time -p env CARGO_BUILD_JOBS=3 RUST_TEST_THREADS=3 scripts/affected-tests mainpasses on7ebcede7: site tests 62.08s, Console browser tests 89.99s, full Rust suite (cargo test, nextest unavailable) 2459.54s, including 1m42s of test compilation. Total wall time 2612.05s. The three-thread setting follows the repository's guidance for short-deadline tests on busy hosts.cargo nextest runstep took 16m53s, excluding queue time; runner parallelism and build caches differ from the local run.cargo clippy --all-targets -j 3 -- -D warnings,cargo fmt --check, andnpm run docs:check --prefix sitepass.PENDING, at a GraphQL cost of 1.Test seams
thirdshift statustext/JSON, backed by fake GitHub responses.Review coverage
Independent
thirdshift-code-reviewStandards and Spec reviews againstmain, plus a follow-up on the 768 px fix: Standards 0 findings; Spec 0 findings. Both axes read all 14 changed files, including the generated manual hunk. No generated-output exclusions. Changed files left unread: none.Reports and final files-read lists:
.thirdshift-review-3TGEDH/standards.md,.thirdshift-review-3TGEDH/spec.md; counts in.thirdshift-review-3TGEDH/summary.jsonbeside the Session trace.Unaddressed findings
Standards
None.
Spec
None.
Security
None.
Security review outcome
No unaddressed introduced findings.
Merge Danger
Door: two-way
Revert the change to remove the indicator. Existing saved GitHub answers remain readable.
Blast Radius: Inbox
Adds latest-head CI to existing read-only GitHub observations and changes row layout. Freshness warnings and minute-based refresh timing still apply.
Built with codex codex-cli 0.164.0 · gpt-6.1-sol · xhigh