Skip to content

Show pull request CI on Ready for review rows - #1650

Merged
JacobStephens2 merged 2 commits into
mainfrom
issue-1649
Oct 30, 2026
Merged

JacobStephens2 merged 2 commits into
mainfrom
issue-1649

Conversation

@JacobStephens2

@JacobStephens2 JacobStephens2 commented Oct 30, 2026 •

Copy link
Copy Markdown
Owner

Summary

Ready for review rows show the connected pull request's latest head CI, refreshed by the existing batched GitHub read. Pending, no checks and unknown answers have their own labels; old cache entries default to unknown. Console and status share the saved answer.

 Inbox GitHub read
   pull request state and settlement time
+  latest commit's combined check/status result
 Ready for review row
   Ready · issue · title
+  CI green | CI red | CI pending | No CI checks | CI unknown

Closes #1649

Evidence

  • Before: cargo test --test console ready_rows_show_current_ci_and_status_reuses_it -- --exact github::ready_rows_show_current_ci_and_status_reuses_it failed waiting for a CI-only Inbox update.
    After: passes, covering SUCCESS/FAILURE/ERROR/PENDING/EXPECTED, no checks, unknown answers, live updates and CLI reuse.
  • Before: node --test --test-name-pattern='Ready rows show CI' console/tests/inbox.test.cjs failed with 768: CI green must be readable.
    After: the retained regression passes at 1440, 768 and 390 px in light/dark Focus and Signal Themes, including live changes, old/unread caches and a page with JavaScript disabled.
  • /usr/bin/time -p env CARGO_BUILD_JOBS=3 RUST_TEST_THREADS=3 scripts/affected-tests main passes on 7ebcede7: site tests 62.08s, Console browser tests 89.99s, full Rust suite (cargo test, nextest unavailable) 2459.54s, including 1m42s of test compilation. Total wall time 2612.05s. The three-thread setting follows the repository's guidance for short-deadline tests on busy hosts.
  • All GitHub CI checks pass on the same head, including Linux Rust tests, the macOS gate, both browser suites and release builds. CI's cargo nextest run step took 16m53s, excluding queue time; runner parallelism and build caches differ from the local run.
  • cargo clippy --all-targets -j 3 -- -D warnings, cargo fmt --check, and npm run docs:check --prefix site pass.
  • A live GitHub query against this PR accepted the new latest-commit selection and returned PENDING, at a GraphQL cost of 1.

Test seams

  • Console Inbox HTTP and event stream, and thirdshift status text/JSON, backed by fake GitHub responses.
  • Rendered Inbox rows in Playwright at desktop and phone widths, including live updates and Theme colours.

Review coverage

Independent thirdshift-code-review Standards and Spec reviews against main, plus a follow-up on the 768 px fix: Standards 0 findings; Spec 0 findings. Both axes read all 14 changed files, including the generated manual hunk. No generated-output exclusions. Changed files left unread: none.

Reports and final files-read lists: .thirdshift-review-3TGEDH/standards.md, .thirdshift-review-3TGEDH/spec.md; counts in .thirdshift-review-3TGEDH/summary.json beside the Session trace.

Unaddressed findings

Standards

None.

Spec

None.

Security

None.

Security review outcome

No unaddressed introduced findings.

Merge Danger

Door: two-way

Revert the change to remove the indicator. Existing saved GitHub answers remain readable.

Blast Radius: Inbox

Adds latest-head CI to existing read-only GitHub observations and changes row layout. Freshness warnings and minute-based refresh timing still apply.

Built with codex codex-cli 0.164.0 · gpt-6.1-sol · xhigh

@JacobStephens2
JacobStephens2 merged commit 9b56b6a into main Oct 30, 2026
18 checks passed
@JacobStephens2
JacobStephens2 deleted the issue-1649 branch October 30, 2026 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

make ready for review section of inbox - the rows there indicate whether the PR connected is CI green or red

1 participant