Repository navigation
Document Experiment results as format 1 - #1504
Merged
Merged
Conversation
Preserve format 1 alongside Experiment names and document the name, name_set and release fields in the initial result contract. Validation: cargo clippy --all-targets -- -D warnings; cargo fmt --check; node --test console/tests/experiments.test.cjs (5 passed); RUST_TEST_THREADS=3 /usr/bin/time -p scripts/affected-tests main (passed, 1808.05 seconds wall time including compilation, 51 site browser tests and the full Rust suite via cargo test).
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #1483. Documents Trial results, Scores and rechecks, and suite Verdicts
with their Bars. No new export.
Evidence
Before:
cargo test --test experiments result_format -- --nocapturefailed with
Experiment.format: missing documented field.After: the same test passed with
format: 1; it checks real fake-Harnessoutput, retained Trial files, rechecks and Session contents. Mutations prove
nested added, removed and retyped Score fields are rejected.
cargo check --testspassed.cargo test --test experiments -- --test-threads=3passed: 85 tests,one ignored (155.17s).
RUST_TEST_THREADS=3 CARGO_BUILD_JOBS=3 /usr/bin/time -p scripts/affected-tests mainpassed all 51 site checks and 1,541 Rust unit tests, then stopped on two
ExecutableFileBusy(Text file busy) errors in the unchanged fixture'sbinary warmup, before Experiment execution. Selector wall time: 769.59s,
including compilation (89s). Both exact serial retries passed:
CI
passed for the exact head
a97f77fb: Linux's fullcargo nextest runandcargo test, formatting/clippy, macOS, site and Console checks. The remaininglocal continuation was stopped after these equivalent full-suite checks
passed; no second local full-suite run was needed.
Test seams
experiment,experimentslist/show,recheckandretained Session reads, using fake Harnesses.
Review coverage
Independent Standards and Spec reviews against
main: 0 findings on each axis.Both reviewers read all eight changed files, including generated
site/docs/index.html. Unread changed files: none. Generated-output exclusions:none. Reports and final files-read lists are retained in
.thirdshift-review-YWv285/{standards.md,spec.md}, with counts insummary.json.Unaddressed findings
Security review outcome
No unaddressed introduced findings.
Merge Danger
Door: two-way
Documentation, a test guard and an additive JSON format marker; no retained
result migration.
Blast Radius: readers
Experiment JSON consumers receive the new top-level
formatfield. Existingfields and scoring behavior stay the same.
Built with codex codex-cli 0.164.0 · gpt-6.1-sol · xhigh