Repository navigation
README, credit and install docs - #15
Merged
Merged
Conversation
The README covers what thirdshift is, install, the runner's prerequisites, usage, logs, Continuation and Failed runs. The mattpocock/skills MIT notice lives in skills/LICENSE, so it is embedded with the Factory skills and written out with them on every Run. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Also say push access is git's, not gh's, and keep the license test's text borrowed instead of copying it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
JacobStephens2
added a commit
that referenced
this pull request
Sep 25, 2026
Resolve src/main.rs and src/run.rs against the pre-flight checks (#15/#16) and the Base branch merge and conflict Repair (#17). Keep main's run structure and carry the progress lines into it: the session log line moves into run_session, the push line into Worktree::push, and the newly built steps (merging the Base branch, starting a Repair) print their lines as issue #10 asks. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
JacobStephens2
added a commit
that referenced
this pull request
Sep 25, 2026
Brings in pre-flight checks (#16), the README (#15) and merging the Base branch with conflict Repair (#17) on top of the Failed run path. - run.rs: preflight::check replaces the inline origin check; the Repair session and final push sit inside implement(), so a failed Repair goes down the Failed run path. The session log reported on failure is the most recent one (repair-1 if it ran). - main.rs: parse the Issue URL up front (exit 2) as main does, then install the interrupt handler and report a FailedRun. - github.rs: main's gh_json/string_field helpers, plus isDraft, is_open, mark_ready and convert_to_draft. - failed_run.rs: reuses Worktree::merge_in_progress. - tests/mergeable.rs: a failed Repair is now a Failed run, so it prints the open PR's URL and sends the PR back to draft. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
5 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A README for someone else to run thirdshift, an MIT LICENSE, and credit to mattpocock/skills with its MIT notice shipped alongside the embedded Factory skills.
Everything from the comment on #11 is in the README: git identity, what sessions leave outside the worktree, installing toolchains up front,
libgbm1for headless Chromium, and subscription usage vstotal_cost_usd.Most of the designed behaviour (pre-flight, Continuation, Failed run, Repairs, progress lines) isn't built yet. The README describes the design, and a Status section says what works today and points to #2.
Tested seam: the
thirdshiftCLI. The new test runs the binary and checks that the plugin directory handed toclaudecontainsskills/LICENSEwith Matt Pocock's MIT notice.Evidence
ships_the_mattpocock_skills_mit_notice_with_the_factory_skillsfails:license: NoneAfter:
cargo test: 9 passed.cargo fmt --checkandcargo clippy --all-targets -- -D warningsare clean.Note:
include_dir!doesn't notice a newly added file underskills/until the crate recompiles. Locally that tooktouch src/plugin.rs. CI andcargo install --path .build fresh, so they are unaffected.Merge Danger
Door: two-way
Docs, license files and one test. The only runtime change is one extra file,
skills/LICENSE, in the temp plugin directory.Blast Radius: negligible
Unaddressed findings
Standards
claude_calls()[0]["plugin_files"][…]in two tests): only two call sites. AScenario::plugin_filehelper can wait for a third, as the reviewer also suggested.Spec
Closes #11
🤖 Generated with Claude Code