Repository navigation
Link an Experiment's Details pane to its Experiment page - #1445
Merged
Merged
Conversation
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Details pane (
Peek) now links an Experiment's Command record to its Experiment page, next to Full Command log. The link appears in every Inbox section and on the Experiments page's row peek.Askama HTML-escapes the id, like the pane's other values. Experiment ids are hex SHA-256 digests (
src/evals/experiment.rs:215).The hand-written site pages (
site/index.html,site/how-it-works/,site/architecture/) don't list the Details pane's links, so none of them needed an edit.Evidence
New tests in
console::peek::tests:cargo test --bin thirdshift console::peek::tests:experiment_record_links_its_experiment_pagefailed. The rendered pane had onlyFull Command log.After: 4 passed, 0 failed.
Other local runs:
cargo fmt --checkpassed.cargo clippy --all-targets -- -D warningspassed.cargo test): 1511 passed and 22 failed. All 22 aresandbox::tests, which fail withsocat is not on PATHon this machine.cargo test --no-fail-fast --test '*'): 71 files, 1587 passed and 22 failed.socat(void_cause: sandbox_unavailable), andsettlement::historical_review_and_reclosed_origin_regressionsneedstomllib, which the local Python 3.9 lacks.dismiss::dismissed_live_command_returns_when_it_dies_fails_or_ends_readyfailed under the parallel run and passed when rerun alone.Merge Danger
Door: two-way
Blast Radius: tiny
The change adds one optional link to the Details pane and nothing else.
Review coverage
Both reviewers read both changed files (
src/console/peek.rs,src/console/peek.html). No changed file was left unread, and nothing was excluded as generated output. The Standards review raised 3 judgement-call smells and the Spec review raised none. S3 is fixed: the test helper is renamedrender_peek.Unaddressed findings
Standards
format!("/experiments/{id}")is now built in a fourth place (src/console/peek.rs,experiment_url). Declined. The other three copies are in the Experiments page renderer (src/console/experiments/render.rs:221,src/console/experiments.rs:85). Gathering them means editing that page, and the issue puts the Experiments page's own Details layout out of scope (Experiment page Details open below the page, leaving the right column blank #1435). This diff follows the existing pattern.value["kind"] == "Experiment"reads untyped show JSON. Declined. The reviewer marked it largely suppressed by the module's documented design:src/console/peek.rs:1says "Render every show field, including nested Runs, without a second schema."Spec
None.
Closes #1438
Built with claude 2.1.311 · claude-opus-5-5 · high
Security review outcome
No unaddressed introduced findings.