Repository navigation
Give live usage-limit stop tests 5s before the agent continues - #1441
Merged
Merged
Conversation
The experiments Baseline warning test allowed 0.3s and the two Codex native-warning Trial tests 0.5s between the warning and the marker that proves the agent kept working. A loaded macOS runner missed that window in CI run 40507532942. Each test still fails with the live limit check removed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1439.
main went red in CI run 40507532942 (41e0175) on
experiments::a_baseline_built_before_this_change_pauses_at_its_live_warning, macOS shard 4 only. The test gave the monitor 0.3s to stop the warned Trial, and a loaded runner missed it.tests/experiments.rs:sleep 0.3tosleep 5after the Baseline'sallowed_warning.tests/trial.rs:sleep 0.5tosleep 5in both Codex native-warning tests, which had the same shape.Passing runs are no slower: the monitor kills the agent during the sleep (the experiments test finishes in 4.2s locally). With
Monitor::checkand theplan_limit_reachedstop insrc/session/recording.rsdisabled, all three tests fail.