Repository navigation
Link Security fix advisories in Command details - #1440
Merged
Merged
Conversation
JacobStephens2
marked this pull request as ready for review
October 27, 2026 14:17
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Security fix dispatches retain advisory metadata before launch, so Command details keeps its links even when the fix fails or is interrupted.
Seams under test: the
secure security-fixandshow --jsonCLI commands; the Console's/peekHTTP response for retained Command records.Evidence
cargo test --test security_run fixing_selects_the_most_severe_record_then_dispatches_one_ticket_before_auditing -- --exactfailed: the advisory list wasnull.After: passes with the selected advisory's URL, title and severity retained through completion.
status_tracks_security_stages_and_nests_the_dispatched_fixalso passes while the dispatched fix is still live.cargo test --test console security_fixes::security_fix_peek_links_advisories_and_marks_the_parent_dispatch_for_every_ending -- --exactfailed on the missing linked advisory line.After:
cargo test --test console security_fixes::passes both tests: multiple advisories, severity/“ungraded”, escaped titles, parent marking, failed/interrupted/incomplete records, and legacy/ordinary records without backfill.cargo checkandcargo fmt --checkpass.scripts/affected-tests mainpassed: all 51 site tests and the full Rust suite (cargo test, since nextest was unavailable)./usr/bin/time -p scripts/affected-tests mainmeasured 2289.34 seconds (38m 9s) wall time, including compilation; Rust test compilation took 2m 58s.4219195b, including Linux, the macOS gate, Console browser checks and site checks.Both independent review axes read all 14 changed files against
main: Standards 0 findings; Spec 0 findings. Unread changed files: none. Generated-output exclusions: none.Merge Danger
Door: two-way
The additive list defaults to empty and is omitted for old or unrelated records; no migration or backfill.
Blast Radius: Console
Command-record metadata, CLI JSON details, and advisory links in the details pane.
Unaddressed findings
Closes #1436
Built with codex codex-cli 0.164.0 · gpt-6.1-sol · xhigh
Security review outcome
No unaddressed introduced findings.