Repository navigation
Count a ready Pass and its ready dispatch on one pull request once (#1428) - #1430
Merged
Merged
Conversation
…1428) A Pickup run that dispatched a Spec run ends ready for review on the Spec run's pull request, so the Inbox gave the Pass a row and lifted the dispatched run out as a second, identical one. A ready dispatched run now gets its own row only when its Pass is not already ready on the same pull request.
This was referenced Oct 27, 2026
Closed
Closed
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1428
Summary
The Inbox evaluation lifted every ready dispatched run into a row of its own. A Pickup run that dispatched a Spec run ends ready for review on that Spec run's pull request, so Ready for review showed the same work twice (count 2, two Dismiss buttons). That contradicts the Inbox note "Each outer Command counts once".
A live or not-ready Pass still surfaces its ready dispatched run, and a ready dispatched run on a different pull request still gets its own row.
Evidence
Seen on the Console and in
thirdshift statusfor orchestration#741 (Pickup run and its Spec run, both on PR #749):New test
a_ready_pass_and_its_ready_dispatch_on_one_pull_request_are_one_row:left: 2, right: 1, failinga_pass_counts_once_with_its_dispatches_their_tickets_and_base_fixes(live Pass still yields 2 rows) is unchanged and passes.cargo test --bin thirdshift: 1508 passed. The 22 failures are allsandbox::tests, which fail on this machine withsocat is not on PATHand do not touch the Inbox.cargo clippy --all-targets -D warningsis clean.Merge Danger
Door: two-way
Display only: no record, label or GitHub write changes.
Blast Radius: Inbox
Ready for review rows and their count in the Console and
thirdshift status. A dismissal recorded against the dropped duplicate row no longer has a row to apply to, which is harmless.