Repository navigation
test: give historical Rust pin Trial more time - #1429
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Give the historical Rust pin test enough Trial time for Python process startup on loaded macOS runners.
Both Arms still run concurrently, and other tests' timeouts stay unchanged.
Closes #1422
Evidence
After:
cargo test --bin thirdshift evals::experiment::execution::tests::trial_installs_its_historical_rust_pin_before_the_session -- --exactpasses with the 30-second budget.pinned Rust 1.99.0 download refused by Trial proxy) and when it is temporarily called twice ("install\ninstall\n"versus"install\n"). Both mutations were restored before committing.cargo test --bin thirdshift evals::experiment::execution::tests: 21 passed.cargo fmt --check: passed./usr/bin/time -p scripts/affected-tests main: passed the full Rust suite via thecargo testfallback; 1434.61 seconds wall time, including 64 seconds of compilation. Unit tests: 1529 passed, 3 ignored; all integration suites passed.Test seam: Trial execution through
Execution::prepareandExecution::run, using the existing fake Arms and Rust tool fixtures.Merge Danger
Door: two-way
Blast Radius: tests
One test can now wait up to 30 seconds when its Trial stalls. The change is easy to revert.
Review coverage
Reviewed against
mainwiththirdshift-code-review: Standards 0 findings; Spec 0 findings. Both reviewers read the only changed file,src/evals/experiment/execution/tests.rs. Unread changed files: none. Generated-output exclusions: none.Unaddressed findings
Built with codex codex-cli 0.164.0 · gpt-6.1-sol · xhigh
Security review outcome
No unaddressed introduced findings.