Skip to content

Check the historical Rust pin without tomllib in the Trial test - #1375

Merged
JacobStephens2 merged 1 commit into
mainfrom
fix-rust-pin-test-py39
Oct 26, 2026
Merged

JacobStephens2 merged 1 commit into
mainfrom
fix-rust-pin-test-py39

Conversation

@JacobStephens2

Copy link
Copy Markdown
Owner

Summary

 fake rustup (Python), in trial_installs_its_historical_rust_pin_before_the_session
-import os, pathlib, sys, tomllib
+import os, pathlib, re, sys
 ...
-    pin = tomllib.loads(rust-toolchain.toml)['toolchain']
-    assert pin['channel'] == '1.99.0'
-    assert pin['components'] == ['rustfmt', 'clippy']
+    pin = rust-toolchain.toml text
+    assert a line  channel = "1.99.0"
+    assert a line  components = ["rustfmt", "clippy"]

The test only. The cargo proxy runs the same script, so the top-level tomllib import failed on macOS runners, whose python3 predates 3.11.

Evidence

  • Before: macOS shard 2 on Void Trials on provider capacity and overload errors #1374 (main plus that PR):
    • Arm Trial protocol failed … proxies/cargo, line 2: import os, pathlib, sys, tomllib → ModuleNotFoundError: No module named 'tomllib'
    • FAIL trial_installs_its_historical_rust_pin_before_the_session
  • After: cargo test --bin thirdshift evals::experiment::execution::tests::trial_installs_its_historical_rust_pin_before_the_session passes on Linux (1 passed). This PR runs the full test:macos suite.

Merge Danger

Door: two-way

Blast Radius: test-only

🤖 Generated with Claude Code

https://claude.ai/code/session_01LSAzXiA6BD9neiPgVQRMKD

The fake rustup in trial_installs_its_historical_rust_pin_before_the_session
imported tomllib, which needs Python 3.11. macOS runners' python3 is older,
so the cargo proxy (the same script) failed at import and the test failed
on every macOS run since #1372. A regex checks the two pin lines instead.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01LSAzXiA6BD9neiPgVQRMKD
@JacobStephens2 JacobStephens2 added the test:macos On a PR into main: run the full 4-shard macOS suite instead of the one-job macOS gate (#893) label Oct 26, 2026
@JacobStephens2
JacobStephens2 merged commit 39d085b into main Oct 26, 2026
21 of 28 checks passed
@JacobStephens2
JacobStephens2 deleted the fix-rust-pin-test-py39 branch October 26, 2026 13:41
@JacobStephens2 JacobStephens2 mentioned this pull request Oct 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

test:macos On a PR into main: run the full 4-shard macOS suite instead of the one-job macOS gate (#893)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant