Repository navigation
Check Security publication window issues before closing them - #1346
Merged
Merged
Conversation
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The post-linking sweep still skips the staged Spec and Tickets. The existing check still requires a private-record link and rejects copied private write-up text. Updated the guide, ADR 0015 and generated manual.
Closes #1324
Evidence
cargo test --bin thirdshift public_text_passing_window_issues_stay_open_in_both_sweepsfailed because passing issue Continue an existing Issue branch #20 was closed.After: all 22 publication tests passed in the final head's unit suite.
cargo test --test security_run passing_window_issues_stay_open_and_are_named_in_activity_in_both_sweepsfailed with zero Activity entries.After: it passed for single fixes and Specs, checking open state, successful dispatch and one entry per sweep.
cargo test --bin thirdshift rejected_window_issue_is_closed_before_a_later_text_read_failsfailed as the Spec reviewer predicted. Closing each rejected issue before reading the next fixed it; the retained test passes.cargo check, formatting and manual regeneration checks passed. Full Linux CI passed on the exact final head3766e88b(16m10s). Site, Console, macOS and both platform builds are green too.scripts/affected-tests mainran for 1102.87s, including the warm-cache Cargo build phase: 50 site checks, 1,492 unit tests and all 123 Security run tests passed. It stopped on systemd 252 warning about this host's unrelatedsnapd.service.SYSTEMD_LOG_LEVEL=err cargo test --test site_deploy the_systemd_units_verifypassed. Successful CI on the exact head covers the remaining tests; no full suite was repeated afterward. Test processes selected Python 3.12 and disabled Git tag signing to avoid host defaults; no repository or global settings changed.Test seams: the existing Security publication interface with its scripted GitHub adapter; the
thirdshift secure security-fixCLI with fake external tools and its on-disk Activity log.Review coverage
Independent Standards and Spec reviews used
git diff main...HEAD, withmainpinned at2944d0425bcb33829549aa4eedbcf81281d8d209. Both reviewers read all nine changed files, including generated HTML, and reviewed the corrective hunks. No changed files were left unread; no generated output was excluded.Standards: 0 findings. Spec: 1 P2 finding, reproduced and fixed in
3766e88b. Reports and final files-read lists are retained with the Session trace asstandards.mdandspec.md.Unaddressed findings
Standards
None.
Spec
None.
Merge Danger
Door: two-way
The change is reversible; no storage format or migration changes.
Blast Radius: publication
Only Security fix publication's public-issue sweeps and their Activity entries change. The accepted public-text rule retains its existing limits, including paraphrases it cannot detect.
Built with codex · gpt-6.1-sol · high