Repository navigation
Let a release skip its Experiment with --no-experiment - #1344
Merged
Merged
Conversation
release.sh only accepted an override after a fail or inconclusive Verdict, so a release had to pay for an Experiment that couldn't give a Verdict, as while every Trial is void (#1341). --no-experiment skips it on a fresh run and every resume, and says so. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LSAzXiA6BD9neiPgVQRMKD
JacobStephens2
added
the
test:macos
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
scripts/release.shruns a release Experiment before pushing, and only accepts an override after the Experiment ends in a fail or inconclusive Verdict. While #1341 is open, every Trial is void and is retried, so cutting 0.16.1 would cost roughly 120 Trials, hours of sessions, just to reach a prompt to answer "release anyway".Change:
--no-experimentskips the release Experiment. It works on a fresh run and on every resume.skipping the release Experiment (--no-experiment) for <commit>in place of the check.--reviewin either order.docs/guide.md's Releasing section describe it, including when to use it. The generatedsite/docs/is regenerated.Tests:
tests/release/experiments.rshas a new test,no_experiment_releases_without_running_one_and_says_so. It covers all three flag orders, asserts that no Experiment is called and the tag is pushed, and failed before this change. All release tests pass.🤖 Generated with Claude Code
https://claude.ai/code/session_01LSAzXiA6BD9neiPgVQRMKD