Repository navigation
Report Unready Ticket blockers and retain graph titles - #1343
Merged
Merged
Conversation
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Tickets checklist and Command log retain the Unready reason and name open blockers. Command records also retain Ticket and blocker titles for
show --json; missing historical titles are documented as best effort. Outcomes, exit codes and scheduling stay unchanged.Closes #1113
Evidence
After: the board, graph-adapter and Spec-run CLI regressions pass. The same live reproduction passes after limiting the initial query to 420,100 possible nodes. The CLI regression exercises a
ready-for-agentlabel beyond the first 40 labels, the PR checklist, Command log, retained titles, unchanged failure/draft outcome and independent Ticket dispatch./usr/bin/time -p scripts/affected-tests mainpassed on2c3d52a0: full Rust suite through thecargo testfallback and all 50 site tests. Wall time: 2,271.83s (37m 52s), including compilation. All applicable CI checks also pass on this exact head.cargo clippy --all-targets -- -D warningspass.cargo test --locked --test pickup_model -- --nocapturepasses its four checks, including both safeguard mutations; the known pre-Claim counterexample remains recorded and its literal assertion remains ignored.Seams tested: TicketBoard’s lines/checklist and next-Ticket interface; GitHub’s Ticket graph reader; Spec-run CLI output and retained
show --jsonobservations.Review coverage: Standards: 0 findings. Spec: 1 finding, SPEC-001, fixed and independently rechecked. Both axes read all 13 changed files, including generated
site/docs/index.html. Their review did not reread the final optional-title-map lookup correction intests/fakes/gh.rs; its existing Activity log integration target passes (12 passed, 1 ignored). No other unread changed files or generated-output exclusions.Unaddressed findings
Security review outcome
No unaddressed introduced findings.
Merge Danger
Door: two-way
No record migration; optional titles remain compatible with existing records.
Blast Radius: Commands
The shared GitHub graph reader is used during Ticket and Spec startup and Pickup. Reporting changes do not widen dispatch to outside blockers.
Built with codex codex-cli 0.164.0 · gpt-6.1-sol · xhigh