Skip to content

Setup: install output points to thirdshift setup - #134

Merged
JacobStephens2 merged 2 commits into
mainfrom
issue-132
Sep 29, 2026
Merged

JacobStephens2 merged 2 commits into
mainfrom
issue-132

Conversation

@JacobStephens2

Copy link
Copy Markdown
Owner

Summary

The installer's last line now points new users to Setup. The installer gains no flags and runs nothing after installing (ADR-0003).

 [dist]
 installers = ["shell"]
 install-path = "~/.local/bin"
+install-success-msg = "Run 'thirdshift setup' to choose your defaults, or just start a Run and thirdshift will offer it."

The README's Install section now mentions thirdshift setup after the install command.

dist generate (cargo-dist 0.33.0, the pinned version) was run and left .github/workflows/release.yml unchanged. The message only ends up in the generated installer script.

Evidence

  • Before: the installer ended without mentioning Setup.
    After: dist build --artifacts=global gives
    target/distrib/thirdshift-installer.sh:719:    say "Run 'thirdshift setup' to choose your defaults, or just start a Run and thirdshift will offer it."
    
  • dist generate: git status is clean afterwards, so the workflow doesn't change.
  • cargo test: all suites pass.

Merge Danger

Door: two-way

Revert the two lines to roll back.

Blast Radius: installer-output

thirdshift setup and the first-Run offer come from #131, which is still open. If a release is cut from this branch before #131 merges, the installer will point users to a command that doesn't exist. Merge after #131.

Unaddressed findings

Standards

  • Points to thirdshift setup, which doesn't exist yet. Skipped: Setup: the first Run offers Setup #131 (this issue's blocker) adds it. Only merge order needs to handle this.
  • "Setup" isn't in the CONTEXT.md glossary. Skipped: it's a domain term defined by thirdshift setup #126. The Setup slice (Setup: the first Run offers Setup #131) adds it with the command, and adding it here would conflict with that change.
  • The sentence is duplicated in the README and the TOML. Skipped: dist needs a literal string, and thirdshift setup #126 wants the docs and the install output to agree.
  • The #user-config link goes to a section that doesn't cover Setup yet. Skipped: thirdshift setup #126/Setup: the first Run offers Setup #131 own that section's Setup text. Setup writes the User config, so the link stays correct.
  • The TOML comment could be shorter. Skipped: it states why there's a message rather than a post-install hook, which is useful.

Spec

  • Depends on merge order relative to Setup: the first Run offers Setup #131. Skipped: this is a process concern, not a code change. It's flagged under Merge Danger above.
  • The commit is titled "thirdshift: failed run (interrupted)". Skipped: the branch is already pushed, so rewriting it would need a force-push. Squash-merge can set the title.

Closes #132

🤖 Generated with Claude Code

2026-09-29T22:19:02Z, host tracewake. Uncommitted work at the time of failure is included in this commit.
@JacobStephens2
JacobStephens2 merged commit 11e755f into main Sep 29, 2026
13 checks passed
@JacobStephens2
JacobStephens2 deleted the issue-132 branch September 29, 2026 22:32
@JacobStephens2 JacobStephens2 mentioned this pull request Sep 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Setup: install output points to thirdshift setup

1 participant