Repository navigation
Setup: install output points to thirdshift setup - #134
Merged
Merged
Conversation
2026-09-29T22:19:02Z, host tracewake. Uncommitted work at the time of failure is included in this commit.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The installer's last line now points new users to Setup. The installer gains no flags and runs nothing after installing (ADR-0003).
[dist] installers = ["shell"] install-path = "~/.local/bin" +install-success-msg = "Run 'thirdshift setup' to choose your defaults, or just start a Run and thirdshift will offer it."The README's Install section now mentions
thirdshift setupafter the install command.dist generate(cargo-dist 0.33.0, the pinned version) was run and left.github/workflows/release.ymlunchanged. The message only ends up in the generated installer script.Evidence
After:
dist build --artifacts=globalgivesdist generate:git statusis clean afterwards, so the workflow doesn't change.cargo test: all suites pass.Merge Danger
Door: two-way
Revert the two lines to roll back.
Blast Radius: installer-output
thirdshift setupand the first-Run offer come from #131, which is still open. If a release is cut from this branch before #131 merges, the installer will point users to a command that doesn't exist. Merge after #131.Unaddressed findings
Standards
thirdshift setup, which doesn't exist yet. Skipped: Setup: the first Run offers Setup #131 (this issue's blocker) adds it. Only merge order needs to handle this.distneeds a literal string, and thirdshift setup #126 wants the docs and the install output to agree.#user-configlink goes to a section that doesn't cover Setup yet. Skipped: thirdshift setup #126/Setup: the first Run offers Setup #131 own that section's Setup text. Setup writes the User config, so the link stays correct.Spec
Closes #132
🤖 Generated with Claude Code