Repository navigation
Split a Spec where a Ticket needs a release of its earlier Tickets - #1339
Merged
Merged
Conversation
Ticket-splitting guidance, in the Factory thirdshift-to-tickets skill and the Day shift publication procedure, now rejects a Ticket that needs a release, deployment or host install of earlier Tickets in its own Spec, and splits the Spec there: Spec A, a ready-for-human release step blocked by it, and Spec B blocked by that step. #700 / #994 is the example. The Factory skill publishes only Spec A's Tickets and reports the rest. Closes #1075
Positive headline and one definition of a release in the skill; say which Tickets spec A keeps; use Spec, Spec run and Day shift step from the glossary; separate the conversion's code from running it. Add the rule to the user manual and regenerate the site. Part of #1075
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ticket splitting now rejects a Ticket that needs a release, deployment or host install of earlier Tickets in its own Spec, and splits the Spec at that point instead. A Spec reaches the Base branch only through its Spec PR, so a Ticket like that blocks its Spec from the start, as #994 did to #700.
Where the rule lives:
The Factory skill creates no Spec and changes none beyond linking its sub-issues, so it publishes only the Tickets that neither need the release nor are blocked by one that does. It leaves the
ready-for-humanissue and Spec B for the Day shift.Evidence
Tickets not done: #994, #995, #996, #997.After: both documents state the rule with that example.
UPDATE_PROMPTS=1 cargo test --bin thirdshift prompts_page, thencargo test --bin thirdshift prompts_page:test result: ok. 12 passed; 0 failed.npm test --prefix site(includesdocs:check):# pass 50,# fail 0.cargo test --no-fail-fastandtag.gpgsign=false. Every target passes except tests that are environmental on this host:sandbox::tests(21), plus 1 inexperimentsand 14 intrial, all failing withsandbox failed to start: socat is not on PATH; and 2 inbug_origins, with socat andNo module named 'tomllib'. Threeworktree::synchronization_testsfailed only under the user'stag.gpgsign=trueand pass with it off. No Rust changed; CI runs the Linux suite.Merge Danger
Door: two-way
Only guidance prose and its generated copies change. Reverting the commits restores the old text.
Blast Radius: guidance
Architecture reviews and Security fix publishing sessions using
thirdshift-to-ticketsmay publish fewer Tickets for a Spec that needs a release partway through, and Day shifts publishing Specs gain one check.Review coverage
Both reviewers read every changed file, including both generated files. No changed file was left unread, and no generated output was excluded.
Unaddressed findings
Standards
docs/agents/triage-labels.md. Declined.AGENTS.mdsends anyone publishing Specs or Tickets to this file's publication procedure, and the issue's Agent Brief namesdocs/agents/triage-labels.mdas the Day shift document. The new section is a sibling of "Day shift publication" (docs/agents/triage-labels.md:31).triage-labels.mdanddocs/guide.md. Declined. The Agent Brief requires that "Both documents state the rule with the example". The skill is embedded in the binary and runs in repositories that have notriage-labels.md(ADR 0001).docs/guide.md:1699speaks to Day shifts in those repositories too.skills/thirdshift-to-tickets/SKILL.md:48).skills/thirdshift-to-tickets/SKILL.md:84: "Do NOT close or modify any parent issue, beyond linking its sub-issues". The Day shift document uses "Spec".docs/guide.mdleads with a prohibition ("keep out of it any Ticket…"). Declined. The guide is a manual for humans, and the writing-for-agents negation rule covers agent-facing text. The skill's headline is now positive.Spec
rg -n "PlanReady\(" src/architect.rs | rg -q "final_message|report|held". It exited 1, so the finding holds:conclude(src/architect.rs:498) reads only the strength line and the last line. Declined here because the Agent Brief puts code checks and readiness changes out of scope and settles on "reports the rest". Whether thirdshift should surface the report, or whetherthirdshift-to-specshould scope the Spec itself, is for the Day shift to decide. Filed as Architect run drops the to-tickets report of work held back for a release #1340.Closes #1075
Built with claude · claude-opus-5-5 · high
Security review outcome
No unaddressed introduced findings.