Repository navigation
Research: what thirdshift can learn from other open-source software factories - #1338
Merged
Merged
Conversation
…actories Covers addyosmani/factory, ProPR, Anneal, Cole Medin's AI Software Factory, DoorDash's Agentic Orchestrator and pocock-agents from their repositories at pinned commits, marking each practice as already in thirdshift, worth adopting, conflicting with a named ADR, or not useful. Refs #836
Mark DoorDash's phase checkpoints as Skip rather than an ADR 0013 conflict, name the gaps in ProPR's read-only token, say that Archon's reviewer still decides the merge, and keep ADR 0004's agreement that no agent merges from inside a session. Credit thirdshift's existing plan-limit pause, give the Built-with line's real format, use Security run where Security audit was wrong, cite the remaining uncited figures, and add a suggestion for Continuations to read review threads. Refs #836
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A new research note,
docs/research/open-source-factories.md, answers #836's question: which practices of other open-source software factories would thirdshift benefit from, which does it already have, and which conflict with its ADRs. No code changes.Each practice is marked Have, Adopt, Conflicts (ADR NNNN) or Skip. Skip is for practices that thirdshift lacks, wouldn't benefit from, and no ADR rules out. The Method says why the three marks the issue names couldn't place these.
The top suggestions:
Gas Town and Sandcastle are left out, since warp-factories-and-alternatives.md and sandcastle-fit.md already cover them.
Evidence
GLOSSARY.md, an ADR or a source file.#Lrange against the file's length. It also fetched every issue and web link, and resolved every relative link.163 unique URLs, 0 failures; all relative links and line anchors resolve. The Spec reviewer re-checked all of them independently, with the same result.scripts/affected-tests origin/mainpicks the full Rust suite for anydocs/research/path. On this host, every failure comes from the host's environment, and none could come from a Markdown file:socatis not installed. 21sandbox::testsunit tests fail with "sandbox failed to start: socat is not on PATH". So do 5 sandboxed integration tests: 1 inexperiments, 3 inscoringand 1 inbug_origins.tests/trial.rs: 14 failures, from the same missingsocat.bwrapis installed, so the harness picks the Trial sandbox, and the sandbox can't start. With a failingbwrapfirst onPATH, the harness takes its documented no-sandbox fallback, and all 26 tests pass.tag.gpgsign=true. Threeworktree::synchronization_testsfail with "no tag message?". All 36 tests in that module pass withGIT_CONFIG_GLOBAL=/dev/null.tomllib.bug_origins::settlement::historical_review_and_reclosed_origin_regressionsfails onModuleNotFoundError: No module named 'tomllib'.cargo test --no-fail-fastwas killed by a session time limit aftertests/spec_push_race.rs. A second run coveredtests/spec_run.rsthroughtests/user_config.rs. CI runs the full suite on this PR too.Merge Danger
Door: two-way
A new Markdown file under
docs/research/. Nothing reads it at build or run time.Blast Radius: none
Unaddressed findings
Standards
~/.claude/fact and the adopt and conflict lists are repeated across the TL;DR, §2-§3 and §4-§5 (Duplicated Code, a judgement call). Declined. Each place serves a different reader: summary, evidence, action list, ADR register. The repository's research notes repeat the same way; sandcastle-fit.md's TL;DR restates its §1-§7.Spec
Security
docs/research/that no build, test, prompt or site page reads; its external links all point atgithub.com, and it holds no scripts, HTML, hidden characters, credentials or local paths.Security review outcome
No unaddressed introduced findings.
Review coverage
The fixed point was
origin/main. Localmainwas two days stale, and would have pulled 405 unrelated commits into the review. Both reviewers read the one changed file,docs/research/open-source-factories.md, in full. No changed file was left unread, and nothing was excluded as generated output.Closes #836
Built with claude · claude-opus-5-5 · high