Repository navigation
Fix warning for issues never labelled ready-for-agent - #1336
Merged
Merged
Conversation
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Direct Ticket runs still warn and continue; Pickup still passes the issue over. Unknown or untrusted label actors keep the existing
ReadyLabelresult.Closes #961
Evidence
cargo test --bin thirdshift trust::tests::an_issue_never_labelled_ready_is_untrusted -- --exactfailed: actual message blamed the label actor; expectedhas never been labelled ready-for-agent.After:
cargo test --bin thirdshift trust::testspassed all 17 tests, including existingReadyLabelcases.cargo test --test fresh_run --test pickup_run: 123 passed, 2 fixture entry points ignored. The new command tests verify the direct warning with successful PR delivery and Pickup's skip reason with no session started.cargo check --all-targets,cargo fmt --check, andgit diff --checkpassed./usr/bin/time -p scripts/affected-tests main: passed the full Rust suite via the documentedcargo testfallback (nextest unavailable), exit 0; wall time 1537.84s (25m 38s), including 43.26s of compilation. Host load and the local cache affect this measurement.d7351350: Linux Rust suite, macOS gate, site and Console browser tests, and both platform artifact builds.Test seams
trust::issue_trustand its returned reason'sDisplay, using the existing in-memory GitHub reads adapter.thirdshift no-merge <Issue URL>CLI: warning text and successful PR delivery.thirdshift pickupCLI: a candidate without ready-for-agent labelling history remains passed over.Review
Independent
thirdshift-code-reviewagainstmain: Standards 0 findings; Spec 0 findings. Both reviewers read all three changed files. Unread changed files: none. Generated-output exclusions: none.Unaddressed findings
Standards
None.
Spec
None.
Security
None.
Security review outcome
No unaddressed introduced findings.
Merge Danger
Door: two-way
The diagnostic distinction can be reverted without migrating data.
Blast Radius: diagnostics
The shared trust reason changes for missing label history; trust eligibility and direct-run continuation stay the same.
Built with codex codex-cli 0.164.0 · gpt-6.1-sol · xhigh