Repository navigation
Show when each repository's Pickup Pass last fired - #1334
Merged
Merged
Conversation
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Pickup, Architect and Security starts are recorded even when they skip. Console ages advance locally while the host is quiet. JSON exposes
pass_starts;cronjobs --jsonnow returns{jobs, pass_starts}rather than a bare job array. Start times include manual launches and do not infer which cron entry fired.Closes #744
Evidence
cargo test --test activity_log an_unchanged_skip_updates_last_fired_without_adding_activity_linesfailed because status had no start inventory.After: it passes, checking distinct starts for unchanged skips while the Activity log retains one line.
After: that command passes (2 sec → 4 sec);
node --test console/tests/cronjobs.test.cjspasses both tests, including quiet-page ages on Inbox and Cron jobs.f7225e5d: full Linux Rust suite, macOS gate, site tests and Console browser tests.scripts/affected-tests mainpassed all 50 site tests locally. Its redundant full Rust run was stopped after exact-head CI passed, followingdocs/testing.md's reuse rule. Local elapsed time: 1,856.48 seconds, compilation included; stopped deliberately rather than reported as a passing local full-suite run.Test seams
status [--json]and Activity log: every start, including repeated skips, updates a per-repository time without adding log lines.status [--json]/ Console Inbox andcronjobs [--json]/ Console Cron jobs: paired per-repository times, JSON and elapsed browser ages.Review coverage
Against fixed
mainate5b48aac: Standards raised 3 heuristic smells; Spec raised 1 P2 behavior finding. All were addressed. Each axis read 22 changed files, including generated documentation, with no generated-output exclusions.Changed file left unread by both axes:
src/console/pass_start.html. This one-line shared fragment fixes the last follow-up duplication finding and was introduced after both axes exhausted their single coverage follow-up. The implementing agent inspected it; paired HTTP and browser tests exercise its output.Unaddressed findings
e5b48aa...HEADdiff introduced no finding. Hostile last-fired content is strict-parsed and skipped, hostile repository names render Askama-escaped, and the new state files are fixed-name same-owner local state. Nine local PoC checks plus the activity_log, status and console cronjobs suites passed.Security review outcome
No unaddressed introduced findings.
Merge Danger
Door: two-way
Reversible local state and reader changes; no migration. Consumers of the former
cronjobs --jsonarray must usejobs.Blast Radius: observability
Affects saved Pass start times, status/cron inventory output and Console age displays.
Built with codex codex-cli 0.164.0 · gpt-6.1-sol · xhigh