[JacobStephens2]

Summary

 # macOS shard on push to main
-cargo nextest run --partition hash:i/4
+cargo nextest run --partition hash:i/4 --no-fail-fast

Each main-push shard reports all failures in one run. PR shards and the macOS gate keep their existing fail-fast behavior, as do nightly and manual runs. Document the setting in docs/ci-performance.md.

Closes #1325

Evidence

• Before: the workflow's shard command, rendered for a main push and run against two deliberate failures with one test thread, reported 1/2 failed, leaving the second unrun.
  After: the updated push command reported 2/2 failed. Both runs correctly returned exit 100. Rendered PR, nightly and manual commands still reported 1/2 failed. Linux command-level probe used nextest 0.9.149, hash:1/1, and the repository's default profile settings.
• Parsed workflow comparison confirms that only the shard nextest command changed; the main-only push trigger, gate and nextest profiles are unchanged.
• Required local validation: PATH=/tmp/thirdshift-1027-tools:$PATH CARGO_BUILD_JOBS=2 NEXTEST_TEST_THREADS=2 scripts/affected-tests main passed: 3,011 passed (7 slow), 66 skipped. Nextest execution took 2,688 seconds with two test threads; fresh compilation took 4m 18s.
• All PR checks are green, including the CI workflow with Linux Rust tests, site/Console browser tests and the macOS gate, plus Release artifact checks.
• Independent review against main: Standards 0 findings; Spec 0 findings.

Merge Danger

Door: two-way

Revert the workflow flag and documentation to restore the previous behavior.

Blast Radius: CI

Failing main-push macOS shards take longer because all tests finish. Failure status is preserved.

Unaddressed findings

Standards

None.

Spec

None.

Security

None.

Security review outcome

No unaddressed introduced findings.

Review coverage

Both reviewers read every changed file: .github/workflows/ci.yml and docs/ci-performance.md. Unread changed files: none. Generated-output exclusions: none. Final reports and finding counts are saved in .thirdshift-review-HQrOtS/standards.md, spec.md and summary.json in the session worktree.

Built with codex codex-cli 0.164.0 · gpt-6.1-sol · xhigh