Repository navigation
Fix main's CI: canonical eval destination, atomic fake records - #1316
Merged
Merged
Conversation
The eval repository test compared the canonical prepared path with the /var temp path, which differs on macOS. Fakes truncated their record file before writing it, so an unlocked reader, or a fake stopped mid-write, could see it empty; they now write beside it and rename. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LSAzXiA6BD9neiPgVQRMKD
JacobStephens2
added
the
test:macos
This was referenced Oct 25, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the last two failures in
main's push CI. #1301 fixed the third.evals::repository::tests::complete_trial_repository_preserves_reviewed_patch_inputs_and_custom_branchescompared the canonical prepared repository with the/var/...temp path. macOS resolves/varto/private/var. The fixture's destination is now canonical.experiments::stop_and_resume_preserve_finished_trials_and_refuse_a_changed_barreadclaude-calls.jsonwhile it was empty. The fakes'append_recordtruncated the file before writing it. It now writes a sibling file and renames it over the record, so a reader, or a fake killed bystop, never sees a partial list. Every fake (gh, claude, codex, muse, agy, grok, opencode) uses this writer.Why
mainkeeps getting these failures: #1315.scripts/affected-tests main: 3004 tests passed.🤖 Generated with Claude Code
https://claude.ai/code/session_01LSAzXiA6BD9neiPgVQRMKD