Repository navigation
Deepen Trial execution and fixed-Bar recovery - #1310
Merged
Merged
Conversation
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Give the Trial module one complete operation and apply the saved Bar's retry rules during recovery.
Closes #1309
Evidence
cargo test --test experiments retained_pending_history_obeys_the_saved_void_cause_list -- --exactfailed: resume launched 4 attempts when the saved Bar allowed only the 2 retained attempts.After: the same regression passes with 2 attempts and retained terminal Void results.
cargo check --all-targetspassed.cargo test --bin thirdshift evals::experiment::passed: 49 tests, including complete Trial recovery/publication, execution cleanup, retained readers, Model Scores and rechecks.cargo fmt --checkandgit diff --checkpassed.scripts/affected-tests mainpassed: all 50 site tests and the full Rust suite, including 80 Experiment command regressions (one fixture entry ignored). It used the documentedcargo testfallback because nextest is unavailable./usr/bin/time -p scripts/affected-tests main: 1420.54 seconds wall time (23m 40.54s), including site checks and 40.99 seconds of Rust compilation. Output is retained as.thirdshift-review-CxJABh/affected-tests.log.8b6d7ad5, including Linux tests, the macOS gate, site and Console checks.Test seams
Review coverage
Independent Standards and Spec reviews against
maineach found 0 issues and read all 13 changed files. Unread changed files: none. Generated-output exclusions: none; both reviewers inspected the generated documentation hunk. Reports are retained with this session as.thirdshift-review-CxJABh/standards.mdand.thirdshift-review-CxJABh/spec.md.Unaddressed findings
Security review outcome
No unaddressed introduced findings.
Merge Danger
Door: two-way
Internal ownership changes preserve the retained format, filenames and Experiment commands. Recovery now obeys older saved cause lists and cannot gain extra attempts after terminal-publication failure.
Blast Radius: Experiments
Retry, pause and publication behavior for Trials; ordinary Ticket runs are unaffected.
Built with codex · gpt-6.1-sol · xhigh