Repository navigation
Make Recording own Interpretation construction - #1296
Merged
Merged
Conversation
This was referenced Oct 25, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Recording now constructs Interpretation from the chosen Harness, Session prompt and prepared Command. Explicit launch HOME redirects native readers for ordinary Sessions and scoped Model Graders alike.
Closes #1295
Seams under test: Recording's direct Command and scoped Invocation interfaces; existing Harness Interpretation and Model Grader recording interfaces.
Evidence
cargo test --bin thirdshift session::recording::tests::explicit_launch_home_stops_private_execution_on_native_codex_quota -- --exact --nocapturefailed withnative warning must stop private execution; the child completed after a native warning in its launch HOME.After: the same regression passes through direct and scoped invocations. Recording tests also verify stale/foreign records, directory spelling, prompt warnings, ordinary/Security policy, retained evidence, interruption and progress ordering.
cargo check --all-targetsandcargo clippy --all-targets -- -D warningspassed./usr/bin/time -p scripts/affected-tests mainpassed: the selector ran the full Rust suite withcargo test(nextest unavailable). Wall time: 1,351.31 seconds (22m 31s), including compilation with cached dependencies.main: both Standards maintenance findings addressed and confirmed in follow-up; Spec has no findings. Both reviewers read all seven changed files. Unread changed files: none. Generated-output exclusions: none.Merge Danger
Door: two-way
Internal ownership change; persisted formats are unchanged.
Blast Radius: Sessions
Session and Model Grader interpretation now follows the actual launch context, including native Codex quota warnings.
Unaddressed findings
778c015.Built with codex · gpt-6.1-sol · xhigh
Security review outcome
No unaddressed introduced findings.