Repository navigation
Deepen Trial execution through completed mechanical Scores - #1292
Merged
Merged
Conversation
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Trial execution owns execution ordering and keeps its guards private through the worker's callback. Workers retain the queue, Writer and fixed Bar policy. The domain-to-code index names both owners.
Closes #1290
Evidence
Trial execution is not implemented.After: all nine focused execution tests pass, covering completed Scores, fallback/mutation, timeout cleanup, unexplained kills/cap precedence, raw/trace native limits, interruption, sandbox rescoring and callback/error lifetime.
cargo check,cargo fmt --checkandcargo clippy --all-targets -- -D warningspass locally.32a97512passes: full Linuxcargo test, macOS gate, Console and site checks. Its log confirms all nine new execution tests pass on that exact commit.scripts/affected-tests mainselected the full Rust suite (2,834 tests across 63 binaries). Perdocs/testing.md's same-head CI reuse rule, the redundant local run was stopped after the exact-head full CI suite passed; it is not reported as a completed local pass.Test seams
execution::Execution::prepareandExecution::run: one selected Trial with real temporary Git repositories and executable Arm/system-manager fixtures, including completed Scores and retained evidence lifetime.Review coverage
.thirdshift-review-aLQJ0z/standards.mdand.thirdshift-review-aLQJ0z/spec.mdin the Session evidence.Unaddressed findings
4ed03e7...HEADdiff: the execution body moved verbatim (relocated monitor differs by one doc-comment line only), the grading timeout value is unchanged, and arm/setup selection stays consistent; all nine execution tests pass. No introduced finding; no PoC, no fix.Security review outcome
No unaddressed introduced findings.
Merge Danger
Door: two-way
Reversible internal ownership change; retained version-1 requests/results and Experiment data stay compatible.
Blast Radius: Trials
Execution ordering and evidence lifetime affect Experiment Trials; scheduling, retry budgets and publication remain worker-owned.
Built with codex · gpt-6.1-sol · xhigh