Repository navigation
Capture retained Experiment views in one observation - #1284
Merged
Merged
Conversation
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #1283. One retained Experiment reading module captures the facts used by CLI text/JSON, Console list/detail and Session-ID selection. Commands, retained formats and displayed accounting stay the same.
Trace writing and export discovery keep their separate lifetime. The domain-to-code index now points to the reading module; the hand-written site descriptions remain accurate.
Evidence
After: six reading-interface tests verify counted reads, controlled pending/active/result publication, absence reuse, pending/terminal distinctions, legacy attempt indices, converted-log identity, span-only usage and malformed/error handling.
cargo check --bin thirdshift: passed.cargo test --bin thirdshift evals::experiment::reading::tests: 6 passed.cargo test --test experiments: 73 passed, 1 fixture entry point ignored; includes usage, retries/Resume, paused minutes, rechecks and Trace export.cargo test --test console experiments::: 3 passed, including CLI/Console pairing and Session-ID evidence selection.cargo clippy --bin thirdshift -- -D warnings,cargo fmt --check,git diff --check: passed./usr/bin/time -p scripts/affected-tests mainselectedcargo nextest run. The local run stopped after 900/2,815 tests: 899 passed, one failed, 60 skipped, and 1,915 not run after fail-fast.run_health::silent_watches_only_session_trace_recordsexpectedsilentbut observedokattests/run_health.rs:189. Wall time was 801.24 s, including 1m 05s compilation.cargo test --test run_health silent_watches_only_session_trace_records -- --exact, passed (1 passed, 0 failed, 0.86 s). No source change was needed for that result.cargo test,cargo clippy --all-targets -- -D warnings, formatting and Python tooling on exact head035c09903f89808653879d67be1fad210da67871. This supplies the complete selected Rust-suite validation; successful CI is reused asdocs/testing.mdrequires. Site, Console browser and macOS-gate checks passed too.Test seams
Review
Independent Standards and Spec reviews used
git diff main...HEAD, including the follow-up at035c0990.Stored::apply_rechecks; no hard violations or outstanding findings..thirdshift-review-tlqX9O/standards.mdand.thirdshift-review-tlqX9O/spec.md(retained with this Session).Unaddressed findings
git diff ee7fe1134d8a98471f0a6498da6ea35b7fbefe80...HEAD(newsrc/evals/experiment/reading.rs, narrowedevidence.rs/usage.rs,store.rsdelegating to one capture). No SECURITY.md or threat model in repo; judged under the skill's resource-and-file-handling and resource-exhaustion classes. Evidence-session canonical-confinement checks are preserved and covered by the escaped-symlink case insrc/evals/experiment/reading/tests.rs(6 reading tests pass). No introduced finding demonstrated with a proof-of-concept, so no fix and no unaddressed introduced finding.Security review outcome
No unaddressed introduced findings.
Merge Danger
Door: two-way
Local retained-reader refactor with no stored-format migration.
Blast Radius: Experiments
CLI and Console retained Experiment projections share this reader. Trial execution, mutation-side reads, locks, grading rules and Trace ancestry/export are unchanged.
Built with codex · gpt-6.1-sol · xhigh