Repository navigation
Complete Spec-review Trial inputs before Experiment builds - #1272
Merged
Merged
Conversation
Preserve both the Trial-input preflight documentation and the Console Experiment page documentation on the homepage.
Keep the Trial-input preflight and Spec-review sandbox documentation alongside the incoming CLI and Console Eval-task approval documentation. Validation: cargo check, cargo fmt --all -- --check, 44 site tests, three Console Experiment browser tests, and all 171 tests in evals, experiments, trial and console passed (three skipped). The affected-tests selector stopped after 400 Rust passes on release::an_interrupted_release_resumes_the_same_experiment, matching the intermittent failure documented in upstream PR #1273. Its isolated cargo test and nextest reruns both passed, and it passed again in the 171-test targeted run. The selector took 432.74s including compilation; the targeted run took 190.67s.
This was referenced Oct 24, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Spec-review imports now copy the original issue/PR URLs and Base/Spec branch names into
[trial]. Reruns fill missing tables and preserve edited tables and other local task edits.Spec-review Trials keep the production prompt. Their sandbox has no PR service:
ghcalls fail and only the reports are graded. Updated the protocol, manual and hand-written site pages.Closes #1251
Evidence
cargo test --test evals replay_import_completes_trial_inputs_and_preserves_local_editsfailed because the Spec-review table was absent. After: all 14 Eval CLI tests pass, including exact manifest values, legacy backfill and preservation of edited tables.cargo test --test experiments spec_review_completed_experiment_uses_saved_inputs -- --exactfailed when a completed Experiment's live table was removed. After: the retained regression passes; it now covers both ordinary and release invocations. The Experiment file passes: 69 passed, one fixture entry point ignored.gh pr viewand still receives the production PR-edit prompt.cargo fmt --check,cargo check, and/usr/bin/time -p scripts/affected-tests issue-977passed ona869d341. The selector passed 44 site tests and 2,566 Rust tests (58 skipped). Nextest reported 2,399.697 seconds; the complete selector took 2,481.77 seconds wall time, including 18.72 seconds of Rust compilation and the site checks.Test seams
evals import-replaysCLI with made-up replay manifests and local edits.experimentCLI with cold Arm caches, fake Cargo and saved Experiments.--trialJSON protocol with a fake Harness and an unavailable PR service.Review
issue-977(298b6b8b9cc60b876dce971dd027ce60b6f27155).site/docs/index.html. No generated-output exclusions. Unread changed files: none.Unaddressed findings
Standards
None.
Spec
None.
Security
None.
Security review outcome
No unaddressed introduced findings.
Merge Danger
Door: two-way
Blast Radius: Evals
Changes affect replay import and new Experiment preparation. Existing edited Trial tables and saved Experiment inputs are preserved.
Built with codex · gpt-6.1-sol · xhigh