Repository navigation
Let Stages fill the window's full width - #1271
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stages (
/?page=stages) drops the Console's 1120 px column and fills the window, keeping only the body's padding. The same holds with Command details (the peek) open, which used to cap the page at 1500 px. Lanes and every other page keep the column they had.The new rule comes after
body.peek-open, so it overrides the 1500 px cap there too. Live updates morph onlymain[data-time-page], and the peek toggles onlypeek-open, so the class stays put. The how-it-works page andconsole/README.mdnow describe the width.Seams under test: the Stages page as rendered in a browser (Playwright,
console/tests/time.test.cjs).Evidence
Stages fills a wide window, with and without the Peek openfailed at 1920 × 1000. The grid sat in a centred column:{"right":1892,"scroll":{"x":428,"width":1064}}. That is about 3.9 run columns of 240 px beside the 140 px stage names.After: the same test passes. The grid starts within the left padding and ends within 1 px of the right padding (about 7.2 run columns at 1920 px). With the peek open,
mainstarts at the left padding and#peekreaches the right padding.node --test tests/time.test.cjs(Console): 9/9 pass.npm test --prefix site: 49/49 pass.cargo test --test console: 104 passed.scripts/affected-tests origin/mainselected the site tests plus the full Rust suite. I rancargo test --no-fail-fast: 61 targets passed. In thethirdshiftbin, 3 tests failed:worktree::synchronization_tests::{base_merges,foreign_observation_and_merge,spec_catch_up}_ignore_shadowing_branch_and_tag_names, each withgit tag … fatal: no tag message?. The cause istag.gpgsign = truein this machine's~/.gitconfig, not this change. With only that setting turned off (GIT_CONFIG_GLOBALpointing at a copy), the bin passes 1328/1328.scripts/affected-tests mainwould have compared against a stale localmainref (a3cabce). This branch sits onorigin/main(6de4820), so the selection and review usedorigin/main.Merge Danger
Door: two-way
One CSS rule and one template attribute. A revert restores the column.
Blast Radius: layout
Stages only. On very wide displays the intro paragraph and title line run the full width too. Phone widths are unchanged: below 1120 px the cap never applied, and the media queries don't touch
max-width.Unaddressed findings
Standards
title == "Stages") rather than astagesflag (Primitive Obsession / Repeated Switches, judgement call). Declined.src/console/time.html:17already branches ontitle == "Lanes"for the same page, andinbox.htmldoes the same for its titles. The new browser test fails if the condition stops matching.body.full-widthbeatsbody.peek-openonly by source order (judgement call). Declined. The test's peek-open assertion (peek.x + peek.width >= right - 1) fails if the rule moves abovebody.peek-open, which caps the page at 1500 px.Spec
None. The Spec review found no missing, extra or wrong behaviour.
Security
None. The new template branch emits a fixed class chosen from a compile-time title (
src/console/time.rs:31), so no request or GitHub data reaches it. The CSS rule changes only the layout width. No trust boundary changed.Security review outcome
No unaddressed introduced findings.
Review coverage
Both reviewers read every file changed at review time.
console/README.mdwas changed after review, in 6e38659, in response to a Standards finding. The Standards reviewer read its Stages paragraph before the edit. Neither reviewer read the edited version. Reports:.thirdshift-review-SltJNg/standards.mdandspec.md.Closes #1262
Built with claude · claude-opus-5-5 · high