Repository navigation
Count same-second Claim hand-backs in either label order - #1263
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A Trusted account can hand started work back in the same edit that removes its Claim, in either listed order. Earlier ready labels still do not count. Update the Ready issue definition and generated manual.
Closes #1261
Evidence
cargo test --bin thirdshift github::execution_tests::a_same_second_hand_back_counts_in_either_timeline_order -- --exactfailed itshanded_backassertion for ready-label-before-Claim-removal.After: the same command passes both orders. Further candidate tests cover a strictly earlier ready label, active same-second Claims, case-insensitive labels and Claim counts; the Pickup regression spans two history pages.
cargo check --testspassed.npm test --prefix sitepassed all 49 checks, including generated-documentation freshness and browser checks.cargo test --locked --test pickup_model -- --nocapturepassed 4 checks (1 known-failing literal assertion ignored). Its claimed-dispatch model explored 70,197 states and both safeguard mutations were detected. The documented pre-Claim dispatch counterexample remains; this does not prove the literal at-most-one-dispatch property. Claim counts, reservations and request ordering retain their existing protocol mapping; timestamp folding is beneath the model's complete-history read./usr/bin/time -p scripts/affected-tests mainpassed: 49 site checks and 2,612 Rust tests across 59 targets (58 expected ignored tests), using thecargo testfallback. Wall time: 1,262.12 seconds (21m 2s), including compilation on a warm dependency cache.555dab7, including Rust, site, Console and the macOS gate; the Rust CI job took 13m 19s of execution time. Linux/macOS artifact builds also passed.Test seams
GitHub::candidate: complete label-history reading through the gh process adapter, observinghanded_back,claimedandclaim_generation.thirdshift pickup: continued work and existing trust/Claim gates through the CLI with fake GitHub.Review coverage
Independent Standards and Spec reviews of
main...HEADeach found 0 issues and read all six changed files, including the generated HTML. No generated output was excluded; no changed file was left unread. Final per-axis reports and files-read lists are retained in the Session review artifacts (standards.mdandspec.md).Unaddressed findings
Security review outcome
No unaddressed introduced findings.
CI notes
console-testintermittently lost the selected row when it moved into folded Done (failed check,console/tests/inbox.test.cjs:737): the test, Console implementation and workflow are unchanged frommain(5dd66ca), and the branch's runtime change is confined to Pickup's candidate label-history handling. Local Console checks passed 78/78 on1614fdc, 40 focused runs onmainpassed, and earlier branch Console CI passed with the same runtime code.Merge Danger
Door: two-way
Revert the commit to restore the old label-history reading; no stored data migration.
Blast Radius: Pickup
Started issues handed back within one second of Claim removal can become Ready. Existing trust, settling and active-Claim gates still apply.
Built with codex · gpt-6.1-sol · xhigh