Skip to content

Count same-second Claim hand-backs in either label order - #1263

Merged
JacobStephens2 merged 3 commits into
mainfrom
issue-1261
Oct 24, 2026
Merged

JacobStephens2 merged 3 commits into
mainfrom
issue-1261

Conversation

@JacobStephens2

@JacobStephens2 JacobStephens2 commented Oct 24, 2026 •

Copy link
Copy Markdown
Owner

Summary

for each label-history timestamp, oldest first:
  replay Claim applications/removals in their existing order
  replay ready-for-agent events
  Released + ready label → HandedBack
  active Claim + ready label → Claimed

A Trusted account can hand started work back in the same edit that removes its Claim, in either listed order. Earlier ready labels still do not count. Update the Ready issue definition and generated manual.

Closes #1261

Evidence

  • Before: cargo test --bin thirdshift github::execution_tests::a_same_second_hand_back_counts_in_either_timeline_order -- --exact failed its handed_back assertion for ready-label-before-Claim-removal.
    After: the same command passes both orders. Further candidate tests cover a strictly earlier ready label, active same-second Claims, case-insensitive labels and Claim counts; the Pickup regression spans two history pages.
  • cargo check --tests passed.
  • npm test --prefix site passed all 49 checks, including generated-documentation freshness and browser checks.
  • cargo test --locked --test pickup_model -- --nocapture passed 4 checks (1 known-failing literal assertion ignored). Its claimed-dispatch model explored 70,197 states and both safeguard mutations were detected. The documented pre-Claim dispatch counterexample remains; this does not prove the literal at-most-one-dispatch property. Claim counts, reservations and request ordering retain their existing protocol mapping; timestamp folding is beneath the model's complete-history read.
  • /usr/bin/time -p scripts/affected-tests main passed: 49 site checks and 2,612 Rust tests across 59 targets (58 expected ignored tests), using the cargo test fallback. Wall time: 1,262.12 seconds (21m 2s), including compilation on a warm dependency cache.
  • Formatting and whitespace checks passed. CI is green on 555dab7, including Rust, site, Console and the macOS gate; the Rust CI job took 13m 19s of execution time. Linux/macOS artifact builds also passed.

Test seams

  • GitHub::candidate: complete label-history reading through the gh process adapter, observing handed_back, claimed and claim_generation.
  • thirdshift pickup: continued work and existing trust/Claim gates through the CLI with fake GitHub.

Review coverage

Independent Standards and Spec reviews of main...HEAD each found 0 issues and read all six changed files, including the generated HTML. No generated output was excluded; no changed file was left unread. Final per-axis reports and files-read lists are retained in the Session review artifacts (standards.md and spec.md).

Unaddressed findings

  • Standards: none.
  • Spec: none.
  • Security: none.

Security review outcome

No unaddressed introduced findings.

CI notes

  • console-test intermittently lost the selected row when it moved into folded Done (failed check, console/tests/inbox.test.cjs:737): the test, Console implementation and workflow are unchanged from main (5dd66ca), and the branch's runtime change is confined to Pickup's candidate label-history handling. Local Console checks passed 78/78 on 1614fdc, 40 focused runs on main passed, and earlier branch Console CI passed with the same runtime code.

Merge Danger

Door: two-way

Revert the commit to restore the old label-history reading; no stored data migration.

Blast Radius: Pickup

Started issues handed back within one second of Claim removal can become Ready. Existing trust, settling and active-Claim gates still apply.

Built with codex · gpt-6.1-sol · xhigh

@JacobStephens2
JacobStephens2 merged commit 6d23146 into main Oct 24, 2026
18 checks passed
@JacobStephens2
JacobStephens2 deleted the issue-1261 branch October 24, 2026 17:28
This was referenced Oct 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

A hand-back made in the same edit as the Claim's removal can be missed

1 participant