Skip to content

Deepen Command reading with shared captured log activity - #1260

Merged
JacobStephens2 merged 2 commits into
mainfrom
issue-1257
Oct 24, 2026
Merged

JacobStephens2 merged 2 commits into
mainfrom
issue-1257

Conversation

@JacobStephens2

@JacobStephens2 JacobStephens2 commented Oct 24, 2026 •

Copy link
Copy Markdown
Owner

Summary

Snapshot
  observed Command: effective outer log + normalized current Session trace
    quiet_age / activity_lengths → shared, lazy length + modification-time sample
    activity_paths → watching, with fresh writer identity checks

Health and Inbox growth reuse each path's first activity sample, including unavailable metadata, until the next Snapshot. Pass dispatches, child Ticket runs and Base fixes inherit their owning Command log during tree assembly. Output formats and health policy stay compatible.

Closes #1257

Evidence

  • Before: cargo test --bin thirdshift command_activity_is_shared_by_health_growth_and_watching_until_the_next_capture failed: the shared Command log had no metadata call through the filesystem adapter (None versus Some(1)).
    After: the retained joint test passes, checking health, growth lengths and watch paths across file/record mutations and a fresh capture. Missing and unreadable metadata, Session normalization, ignored previous Sessions/spans, future times, serialization and lazy ended-record sampling are covered.
  • cargo check --bin thirdshift passed.
  • cargo test --bin thirdshift logs::reading::tests: 28 passed.
  • cargo test --test run_health: 5 passed, 1 fixture entry point ignored.
  • cargo test --test console heartbeat_observes_log_lengths_and_is_flat_for_silent_runs: 1 passed.
  • cargo test --test console watching::: 5 passed, including native wakeups, outcome before writer exit and final-byte draining.
  • /usr/bin/time -p scripts/affected-tests main passed: full Rust suite via the documented cargo test fallback, 1239.74 seconds wall time (20m40s), including compilation (36.36 seconds). No failed tests.
  • cargo fmt --check and git diff --check passed. Console browser checks remain in CI.

Test seams

  • Snapshot capture and observed Command activity operations (quiet age, length pair and watch paths), through the existing Files adapter.
  • Existing CLI Run health, Console heartbeat and native watching interfaces, including captured writer lifetime and final-byte draining.

Review coverage

Independent thirdshift-code-review reviews used main (fa2d80dcde66ad964b8c883f81d1f3d540358206) as the fixed point. Standards: 0 findings. Spec: 0 findings. Each axis read all eight changed files; unread changed files: none. Generated-output exclusions: none. Reports and each axis's final files-read list are saved in .thirdshift-review-licoiy/standards.md and .thirdshift-review-licoiy/spec.md beside the Session trace.

Unaddressed findings

  • Standards: None.
  • Spec: None.
  • Security: None.

Security review outcome

No unaddressed introduced findings.

Merge Danger

Door: two-way

Internal read-only refactor; no retained-record or serialized-observation format changes.

Blast Radius: observations

CLI health, Console Inbox growth and live watching share the captured activity interface.

Built with codex · gpt-6.1-sol · xhigh

@JacobStephens2
JacobStephens2 merged commit 6de4820 into main Oct 24, 2026
18 checks passed
@JacobStephens2
JacobStephens2 deleted the issue-1257 branch October 24, 2026 15:54
This was referenced Oct 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Deepen Command reading with shared captured log activity

1 participant