Repository navigation
Deepen Command reading with shared captured log activity - #1260
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Health and Inbox growth reuse each path's first activity sample, including unavailable metadata, until the next Snapshot. Pass dispatches, child Ticket runs and Base fixes inherit their owning Command log during tree assembly. Output formats and health policy stay compatible.
Closes #1257
Evidence
cargo test --bin thirdshift command_activity_is_shared_by_health_growth_and_watching_until_the_next_capturefailed: the shared Command log had no metadata call through the filesystem adapter (NoneversusSome(1)).After: the retained joint test passes, checking health, growth lengths and watch paths across file/record mutations and a fresh capture. Missing and unreadable metadata, Session normalization, ignored previous Sessions/spans, future times, serialization and lazy ended-record sampling are covered.
cargo check --bin thirdshiftpassed.cargo test --bin thirdshift logs::reading::tests: 28 passed.cargo test --test run_health: 5 passed, 1 fixture entry point ignored.cargo test --test console heartbeat_observes_log_lengths_and_is_flat_for_silent_runs: 1 passed.cargo test --test console watching::: 5 passed, including native wakeups, outcome before writer exit and final-byte draining./usr/bin/time -p scripts/affected-tests mainpassed: full Rust suite via the documentedcargo testfallback, 1239.74 seconds wall time (20m40s), including compilation (36.36 seconds). No failed tests.cargo fmt --checkandgit diff --checkpassed. Console browser checks remain in CI.Test seams
Review coverage
Independent
thirdshift-code-reviewreviews usedmain(fa2d80dcde66ad964b8c883f81d1f3d540358206) as the fixed point. Standards: 0 findings. Spec: 0 findings. Each axis read all eight changed files; unread changed files: none. Generated-output exclusions: none. Reports and each axis's final files-read list are saved in.thirdshift-review-licoiy/standards.mdand.thirdshift-review-licoiy/spec.mdbeside the Session trace.Unaddressed findings
Security review outcome
No unaddressed introduced findings.
Merge Danger
Door: two-way
Internal read-only refactor; no retained-record or serialized-observation format changes.
Blast Radius: observations
CLI health, Console Inbox growth and live watching share the captured activity interface.
Built with codex · gpt-6.1-sol · xhigh