Repository navigation
Wait for release Experiments before publishing - #1235
Merged
Merged
Conversation
This was referenced Oct 24, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Releases wait for an Experiment against the last release tag on touched Eval suites.
A pushed bump branch is checked again before opening its PR. Update the manual and hand-written site pages. Wait for fonts before browser layout assertions to avoid measuring a fallback typeface.
Closes #1022
Evidence
interrupted_release_before_push_keeps_its_experiment_when_main_movesregression failed with two different Candidates.After: the release CLI tests pass, including real SIGINT/resume. The exact review regression passes with the original Candidate retained.
cargorelease tests cover pass, fail/inconclusive overrides, pending rechecks, resume, and skip notes. The compact-help regression and both focused 320px layout checks pass. Clippy with warnings denied and all 14 Python tooling tests pass./usr/bin/time -p scripts/affected-tests 42bad19bb424fd31111add2ed36eb05034a5eb74passed: 2,563 Rust tests (58 skipped), 44 browser tests, and the selected release-generator Python check. Total wall time: 1,388.57 seconds, including 11.84 seconds of Rust compilation; Nextest execution: 1,318.191 seconds.cb172f4c.Test seams
cargoat the external command seam.Review
Independent Standards and Spec reviews against
issue-977at42bad19b: both Standards findings and the Spec finding are addressed. The Spec finding's supplied test was run verbatim, failed before the fix, and passes afterward.Both axes read all 16 implementation/review-fix files, including generated
site/docs/index.html; no generated output was excluded. A subsequent fixture change,site/tests/pages.test.cjs, was left unread by both axes and is disclosed in both saved reports. It waits for fonts before the existing layout assertions; the focused tests pass.Unaddressed findings
42bad19b; no introduced finding confirmed; the 6 fake-cargorelease-gate tests pass).Security review outcome
No unaddressed introduced findings.
Merge Danger
Door: two-way
Blast Radius: Releases
Adds a local release-candidate Git ref until the branch push. Fail or inconclusive Verdicts require explicit permission; EOF stops before publishing more release artifacts.
Built with codex · gpt-6.1-sol · xhigh