Repository navigation
Show recorded finish times and explicit ages in Inbox rows - #1213
Merged
Merged
Conversation
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Shared Inbox rows show each Command's recorded finish in UTC, with its original instant in semantic
<time datetime>markup. Done, Needs you, Ready for review, Resolved, nested Ticket runs and History share the presentation. Live rows keep their start age; unavailable finishes say “End time unknown”. Legacy modification-time estimates still serve retention but are not presented as recorded finishes. The existing refresh path updates relative age, and the server renders the information without JavaScript.Closes #1207
Evidence
cargo test --test console ended_rows_distinguish_finish_age_from_run_durationfailed because the row lacked52 min ago. The unavailable-finish regression also failed because a legacy modification-time estimate appeared as a finish.After: both regressions pass;
cargo test --test console inbox::passes all 11 focused checks, including offset/instant preservation, distinct parent/child finishes, retained Activity logs, shared ended states and live rows.node --test console/tests/inbox.test.cjs: 29 passed, including 320 px without JavaScript, all built-in Themes and existing refresh crossing from seconds to minutes while preserving the finish instant.cargo clippy --all-targets -- -D warnings: passed.tag.gpgSign=true, causing Git to request an editor. An exact rerun passes withGIT_CONFIG_COUNT=1 GIT_CONFIG_KEY_0=tag.gpgSign GIT_CONFIG_VALUE_0=false; the affected-check rerun uses that process-only override. Account configuration was left intact.scripts/affected-tests mainpassed all 49 site checks and the Rust suites through Session traces, setup and logs, then stopped atsite_deploy: this host's installedsnapd.serviceemits an unsupportedRestartModewarning. Direct verification succeeds silently withSYSTEMD_UNIT_PATH=/usr/lib/systemd/system, excluding host enablement links. The remaining targets are validated with that process-only unit-path override plus the Git override, without repeating already-green suites. The affected run took 977.16 seconds with a warm Cargo build.SYSTEMD_UNIT_PATH=/usr/lib/systemd/system GIT_CONFIG_COUNT=1 GIT_CONFIG_KEY_0=tag.gpgSign GIT_CONFIG_VALUE_0=false cargo test --test site_deploy --test spec_push_race --test spec_run --test status --test stop --test toolchain --test update --test user_config.Test seams
Review
main, includingsite/docs/index.htmldirectly..thirdshift-review-UuuBYR/standards.mdand.thirdshift-review-UuuBYR/spec.md.Unaddressed findings
Standards
None.
Spec
None.
Merge Danger
Door: two-way
Presentation and reader-only timestamp provenance; no persisted format or retention policy change.
Blast Radius: Console
Shared row text and wrapping across Inbox and History; documentation follows the new display.
Built with codex · gpt-6.1-sol · high