Skip to content

Show recorded finish times and explicit ages in Inbox rows - #1213

Merged
JacobStephens2 merged 3 commits into
mainfrom
issue-1207
Oct 24, 2026
Merged

JacobStephens2 merged 3 commits into
mainfrom
issue-1207

Conversation

@JacobStephens2

@JacobStephens2 JacobStephens2 commented Oct 24, 2026 •

Copy link
Copy Markdown
Owner

Summary

- ended · acme/widgets#7 · 52 min
+ ended · acme/widgets#7 · Ended Oct 23, 2026 at 23:03:17 UTC · 52 min ago

Shared Inbox rows show each Command's recorded finish in UTC, with its original instant in semantic <time datetime> markup. Done, Needs you, Ready for review, Resolved, nested Ticket runs and History share the presentation. Live rows keep their start age; unavailable finishes say “End time unknown”. Legacy modification-time estimates still serve retention but are not presented as recorded finishes. The existing refresh path updates relative age, and the server renders the information without JavaScript.

Closes #1207

Evidence

  • Before: cargo test --test console ended_rows_distinguish_finish_age_from_run_duration failed because the row lacked 52 min ago. The unavailable-finish regression also failed because a legacy modification-time estimate appeared as a finish.
    After: both regressions pass; cargo test --test console inbox:: passes all 11 focused checks, including offset/instant preservation, distinct parent/child finishes, retained Activity logs, shared ended states and live rows.
  • node --test console/tests/inbox.test.cjs: 29 passed, including 320 px without JavaScript, all built-in Themes and existing refresh crossing from seconds to minutes while preserving the finish instant.
  • cargo clippy --all-targets -- -D warnings: passed.
  • The first full Rust run hit three existing Worktree tag fixtures because this host sets global tag.gpgSign=true, causing Git to request an editor. An exact rerun passes with GIT_CONFIG_COUNT=1 GIT_CONFIG_KEY_0=tag.gpgSign GIT_CONFIG_VALUE_0=false; the affected-check rerun uses that process-only override. Account configuration was left intact.
  • scripts/affected-tests main passed all 49 site checks and the Rust suites through Session traces, setup and logs, then stopped at site_deploy: this host's installed snapd.service emits an unsupported RestartMode warning. Direct verification succeeds silently with SYSTEMD_UNIT_PATH=/usr/lib/systemd/system, excluding host enablement links. The remaining targets are validated with that process-only unit-path override plus the Git override, without repeating already-green suites. The affected run took 977.16 seconds with a warm Cargo build.
  • Completed Rust coverage: the binary's 1,270 unit tests passed; all integration targets passed across the affected run and continuation. The continuation passed in 252.12 seconds: SYSTEMD_UNIT_PATH=/usr/lib/systemd/system GIT_CONFIG_COUNT=1 GIT_CONFIG_KEY_0=tag.gpgSign GIT_CONFIG_VALUE_0=false cargo test --test site_deploy --test spec_push_race --test spec_run --test status --test stop --test toolchain --test update --test user_config.

Test seams

  • Console HTTP pages backed by fixture Command records and retained Activity logs: finish formatting, semantic time markup, shared states, nested children and unknown times.
  • Console browser pages and existing live refresh: visible finish information without JavaScript, phone layout, Themes and relative-age refresh.

Review

  • Standards: no findings. Spec: no findings. Both reviewed all 11 changed files against main, including site/docs/index.html directly.
  • Changed files left unread: none. Generated-output exclusions: none.
  • Full reports and each axis's final files-read list are retained in the Session artifacts at .thirdshift-review-UuuBYR/standards.md and .thirdshift-review-UuuBYR/spec.md.

Unaddressed findings

Standards

None.

Spec

None.

Merge Danger

Door: two-way

Presentation and reader-only timestamp provenance; no persisted format or retention policy change.

Blast Radius: Console

Shared row text and wrapping across Inbox and History; documentation follows the new display.

Built with codex · gpt-6.1-sol · high

@JacobStephens2
JacobStephens2 merged commit f0b75e9 into main Oct 24, 2026
18 checks passed
@JacobStephens2
JacobStephens2 deleted the issue-1207 branch October 24, 2026 01:11
@JacobStephens2 JacobStephens2 mentioned this pull request Oct 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Show when Inbox runs ended, with an explicit time-ago label

1 participant