Repository navigation
Record #919's grilling: Dismissal, and the Inbox reading GitHub (ADR 0023) - #1188
Merged
Merged
Conversation
…a batched lookup costs
… Round 2 Jacob agreed to all four recommendations, widening Dismissal to every row in Needs you or Ready for review, Silent and Slow included (Q1.2). The glossary gains Dismissal, and its Console, Inbox, Needs you and Activity log entries mention it and the Inbox's new GitHub exits. ADR 0016's amendment now names Ready for review beside Needs you. Round 2 asks what brings a dismissed row back, how collapsed rows dismiss, which GitHub facts move a row and who reads them, whether age still moves a row GitHub says is waiting, the command and undo, where a row goes, Findings, and whether reading GitHub gets its own ADR.
Jacob agreed to all nine recommendations, noting that the Inbox now works more like a mail inbox: Needs you and Ready for review keep a row until it is dealt with, and age clears only what GitHub can't speak for (Q2.5). ADR 0023 records that the Console reads GitHub once a minute and why; ADR 0022 was taken on main meanwhile. ADR 0016 points to it. The glossary's Dismissal, Inbox, Needs you and Activity log entries now say what brings a dismissed row back, that a dismissal can be taken back, and how GitHub settles a row. Round 3 asks what happens when GitHub can't be read, how the reads give way to the factory's quota, how long a row is read for, where a row that leaves late goes, whether GitHub moves live rows, where the Console offers Dismiss, settings, what a waiting row shows of GitHub, dismissing several rows, the "(title unavailable)" rows, and how #919 is published.
Jacob agreed to all eleven recommendations, and will publish the Spec and its Tickets with to-spec and to-tickets (Q3.11). ADR 0023 now says what the Inbox does when GitHub can't be read, how the Console leaves the last tenth of the quota to the factory, how long a row is read for, that GitHub moves only ended rows, that Resolved counts from when a row stopped waiting, and that none of it is a setting. The glossary's Inbox entry says Resolved's new clock. Round 4 asks whether to merge main into this branch, take its Ticket run wording, and land the docs before the Spec, and whether a row that ages out still skips Resolved.
…g out still skips Resolved Jacob agreed to both recommendations. A row that ages out isn't one anybody dealt with, so it still goes straight to History (Q4.2); the glossary's Inbox entry and ADR 0023 say so. Q4.1 merges main into this branch next, takes its Ticket run wording, and opens a docs-only pull request before the Spec is written.
# Conflicts: # GLOSSARY.md
A dispatched run is now the Spec run or Ticket run an Architect run or Security run dispatched, and a Pickup run is skipped while another Pass, or the run it dispatched, is still running on its repository.
This was referenced Oct 23, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#919's grilling, finished: four rounds, every question answered. This lands its record, glossary and ADRs before
/to-specwrites the Spec, so the Spec and every session that builds it read them (Q4.1). No code changes.How an ended row leaves Needs you, once the Spec is built:
Ready for review gets the same treatment: a ready Command leaves once its pull request is merged or closed. Both groups now keep a row until it's dealt with, not until it's old.
mainis merged in. The new glossary text and ADR 0023 usemain's Ticket run. The grill file keeps the words it was written in, as ADR 0022 allows for dated records.Evidence
After:
git diff --stat origin/main...dismiss-grilltouches onlyGLOSSARY.md, ADR 0016, ADR 0023 and the grill file. No test reads them, and CI runs the full suite.Merge Danger
Door: two-way
Docs only. Reverting the merge commit undoes it.
Blast Radius: docs
Until #919's Spec is built, the glossary and ADR 0023 describe a Dismissal and GitHub-driven exits the code doesn't have yet, as #698's amendments did before its build. Sessions that read the glossary in the meantime will see the decided rules. #1083's PR #1180 rewrites the same Inbox line in
GLOSSARY.md, so whichever merges second resolves it, keeping #1083's later-Command exit and GitHub's.