Repository navigation
Take the highest-numbered Ready issue with pickup.order or highest-first - #1185
Merged
Merged
Conversation
A Pickup run takes the lowest-numbered Ready issue by default. Set pickup.order to highest-first in the User config, or pass lowest-first or highest-first on the command, to choose which end of the issue numbers it takes from. Two schedules working through the same queue from opposite ends collide less often; the origin reservation still protects either choice. Closes #1109
The CI fmt check flagged unformatted lines in the new pickup order code. This is a formatting-only change with no behavior change.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A Pickup run takes the lowest-numbered Ready issue by default.
pickup.orderin the User config and
lowest-first/highest-firston the command choosewhich end of the issue numbers it takes from, so two schedules can work
through the same queue from opposite ends and collide less often. The origin
reservation still protects either choice.
secureandthirdshift <Issue URL>reject the order words; an invalidpickup.orderstops the pass before any work, naming the file and key.Guide, User-config reference,
help, GLOSSARY and the hand-written sitepages are updated in the same commit;
site/docs/index.htmlis regeneratedfrom the guide.
Evidence
thirdshift pickupalways took the lowest-numbered Readyissue; no setting or flag could change that.
cargo test --bin thirdshift ready::tests— 27 passed, includinghighest_first_takes_the_highest_ready_issue_passing_over_downwardand
highest_first_gives_no_line_to_a_ticket_above_its_ready_spec.cargo test --test pickup_run highest_first|lowest_first|pickup_order— end-to-end: the flag takes each end, the config sets the default,
the flag beats the config, invalid values are rejected before any
work (
gh_calls()empty).cargo test --test pickup_model— claimed-dispatch property holds(4 passed, 1 ignored: the known literal-property assertion).
scripts/affected-tests main— full selection green on this head(exit 0): binary unit tests, all integration targets, site checks.
Merge Danger
Door: two-way. The default preserves existing behaviour exactly; a
revert restores lowest-first-always with no migration.
Blast Radius: pickup selection order. Hosts on the default config see
no change. A host set to
highest-firsttakes the opposite end of thequeue; mixed hosts are the point, and the origin reservation plus
Claim-generation recheck still prevent double dispatch.
Unaddressed findings
None. Standards reported 0 hard violations (2 dismissed judgement calls)
and Spec reported 0 missing, 0 creep, 0 wrong; neither axis made a
behaviour-wrong finding, so no finding was skipped and no
needs-triageissue was filed.
Security review outcome
No unaddressed introduced findings.
Review coverage
No changed file left unread: all 16 changed files were read by at least
one axis except
site/docs/index.html, which is generated outputexcluded by both reviewers (source
docs/guide.md, regenerated in-sessionvia
cd site && npm ci && npm run docs, hunks confirmed one-to-one).Full reports:
.thirdshift-review-fODzJU/standards.md,.thirdshift-review-fODzJU/spec.md.Closes #1109
Built with muse · default model · default effort