Repository navigation
Write test executables through child processes - #1184
Merged
Merged
Conversation
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #1110
Test seams
console_installintegration test binary.Evidence
cargo test --test console_install, fourconcurrent: 46 passed, 4 failed with
ExecutableFileBusy: Text file busy(repetitions 3, 6, 31 and 46; 22.92 seconds).
After: the same 50 repetitions at
e4923c7all passed (60.80seconds while the full suites were also running). The first implementation
also passed 50/50 in 28.45 seconds.
cargo clippy --all-targets -- -D warningsandcargo fmt --checkpassed onfinal HEAD
bac9e7e.bac9e7egives theimport the same Linux guard. The updated macOS gate passed. Final-commit Linux
Rust, site, Console and release build checks also passed in
GitHub checks.
/usr/bin/time -p scripts/affected-tests mainpassed: 2,417 Rust tests passed,56 skipped. Wall time: 2,142.21 seconds, including compilation and build-lock
waits while other validation was running.
/usr/bin/time -p cargo testpassed. Wall time: 2,188.79 seconds, includingcompilation (23.17 seconds) and build-lock waits. Both local full-suite runs
overlapped on this shared host.
Review coverage
Independent Standards and Spec reviews against
mainread all 19 changed files,including fresh final reviews through
bac9e7e. Standards' one initial optionalDuplicated Code finding was addressed by sharing executable copies. Both final
reviews reported no findings.
Changed files left unread: none, on either axis. Generated-output exclusions:
none. Final reports are retained with the Session trace.
Unaddressed findings
Standards
None. The sole finding was addressed in
e4923c7.Spec
None; no findings were reported.
Security
None. Focused review of the
3016eda...HEADdiff (test-only: test-supportwrite_executable/copy_executableplus call-site conversions) found no introduced trust-boundary violation. The helper passes the path as a positional shell parameter inside double quotes and the contents over stdin, and copies viacpwith no shell, so test-controlled paths and contents cannot inject shell commands; all changed sources are#[cfg(test)]or integration tests, so no production behavior changed. No proof-of-concept test was warranted and none was added.Security review outcome
No unaddressed introduced findings.
Merge Danger
Door: two-way
Blast Radius: tests
Test fixtures and shared test support. Reverting restores the executable-write
race.
Built with codex · gpt-6.1-sol · xhigh