Repository navigation
Fix Stages rows to follow Ticket run progression - #1182
Merged
Merged
Conversation
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stages rows now follow the order a Ticket run progresses through, followed by
other Command kinds and unfamiliar stage names. The shared grid derives the
order and names from one
StageNamedeclaration.Test seams
Evidence
cargo test --test console stages_orders_known_rows_by_run_progression_then_unknown_names -- --exactfailed:A future stageappeared first andimplementnear the bottom.After: the same test passes, checking every known stage, two unknown names, repeated stages, both Stages routes and both tables for a repository spanning four Command records.
cargo fmt --checkandgit diff --checkpassed.cargo check --all-targetspassed./usr/bin/time -p scripts/affected-tests mainpassed; it selectedcargo nextest run: 2,416 passed, 55 skipped, including the existing stage-time/Usual-range parity checks. Wall time 1,483.97 s, including compilation (Cargo reported 1m 50s); test execution 1,372.386 s. Nine tests were slow; none failed.Merge Danger
Door: two-way
No stored-record format changes.
Blast Radius: Console
Stage-row ordering in the shared grid; cell contents and Usual ranges retain their existing generation.
Review coverage
Independent Standards and Spec reviews against
main: 0 findings on each axis.Both reviewers read all four changed files:
console/README.md,src/logs/command_record.rs,src/logs/status/time.rs, andtests/console.rs.Unread changed files: none on either axis. Generated-output exclusions: none.
Reports, including supporting files read, are retained beside the Session trace.
Unaddressed findings
StageName::knownsemantics unchanged; unknown stage names render Askama-escaped on HEAD (a<script>stage-name probe returns no raw payload, only<...>entities, and the escaping templates/filters are untouched by this diff); new ordering regression test passes. No PoC failed, so no merge-base classification run was needed.Closes #1105
Built with codex · gpt-6.1-sol · xhigh
Security review outcome
No unaddressed introduced findings.