Skip to content

Fix Stages rows to follow Ticket run progression - #1182

Merged
JacobStephens2 merged 3 commits into
mainfrom
issue-1105
Oct 23, 2026
Merged

JacobStephens2 merged 3 commits into
mainfrom
issue-1105

Conversation

@JacobStephens2

@JacobStephens2 JacobStephens2 commented Oct 23, 2026 •

Copy link
Copy Markdown
Owner

Summary

Stages rows now follow the order a Ticket run progresses through, followed by
other Command kinds and unfamiliar stage names. The shared grid derives the
order and names from one StageName declaration.

- Architecture review → CI watch → Repair → … → cleanup → implement → pull request
+ implement → Resume → Security review → pull request → CI watch → Repair → Self-merge → cleanup
+ other Command stages → unknown names (alphabetical)

Test seams

  • Command records → Console Stages HTTP page: canonical row order across repository tables, unknown-name retention and stable ordering.

Evidence

  • Before: cargo test --test console stages_orders_known_rows_by_run_progression_then_unknown_names -- --exact failed: A future stage appeared first and implement near the bottom.
    After: the same test passes, checking every known stage, two unknown names, repeated stages, both Stages routes and both tables for a repository spanning four Command records.
  • cargo fmt --check and git diff --check passed.
  • cargo check --all-targets passed.
  • /usr/bin/time -p scripts/affected-tests main passed; it selected cargo nextest run: 2,416 passed, 55 skipped, including the existing stage-time/Usual-range parity checks. Wall time 1,483.97 s, including compilation (Cargo reported 1m 50s); test execution 1,372.386 s. Nine tests were slow; none failed.

Merge Danger

Door: two-way

No stored-record format changes.

Blast Radius: Console

Stage-row ordering in the shared grid; cell contents and Usual ranges retain their existing generation.

Review coverage

Independent Standards and Spec reviews against main: 0 findings on each axis.
Both reviewers read all four changed files: console/README.md,
src/logs/command_record.rs, src/logs/status/time.rs, and tests/console.rs.
Unread changed files: none on either axis. Generated-output exclusions: none.
Reports, including supporting files read, are retained beside the Session trace.

Unaddressed findings

  • Standards: none.
  • Spec: none.
  • Security: none. Guidance-mode review of the ordering-only change (console/README.md, src/logs/command_record.rs, src/logs/status/time.rs, tests/console.rs): no new trust boundary, sink, or auth path; StageName::known semantics unchanged; unknown stage names render Askama-escaped on HEAD (a <script> stage-name probe returns no raw payload, only &#60;...&#62; entities, and the escaping templates/filters are untouched by this diff); new ordering regression test passes. No PoC failed, so no merge-base classification run was needed.

Closes #1105

Built with codex · gpt-6.1-sol · xhigh

Security review outcome

No unaddressed introduced findings.

@JacobStephens2
JacobStephens2 merged commit 3016eda into main Oct 23, 2026
18 checks passed
@JacobStephens2
JacobStephens2 deleted the issue-1105 branch October 23, 2026 21:05
@JacobStephens2 JacobStephens2 mentioned this pull request Oct 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The Stages page orders stages alphabetically instead of in the order a Run goes through them

1 participant