Repository navigation
Add Code review Trials and suite execution - #1135
Merged
Merged
Conversation
This was referenced Oct 23, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the review-only Session kind and Session prompt, uses the implement session's reviewer-independence rules, and regenerates the prompts page. Replay imports now supply the required Code review Trial inputs; reimport completes missing legacy inputs while preserving local criteria, comments and custom Trial inputs.
Closes #1016
Evidence
a_code_review_trial_reviews_the_prepared_diff_and_keeps_both_reportsfailed with unknowncode-review; the Experiment regression failed atCode-review Trials require #1016.After: both regressions pass, including mixed outcomes proving pass^3 is 1 for an Arm passing all three Trials and 0 for an Arm passing only two.
Eval task needs a [trial] table.After: the retained regression imports a suite, runs all six Trials, keeps both reports, and reports pass^3. The legacy-import regression also passes and preserves local edits.
cargo test --test evals --test experiments --test trial: 56 passed, 2 subprocess entrypoints ignored after merging the updated Base branch. Both Code review regressions and the mechanical-score regression pass after the fixture cleanup.cargo test --bin thirdshift prompts_page: 12 passed; regeneration and docs checks pass. Site browser checks: 43 passed.cargo check --all-targetsandcargo fmt --checkpass. CI on the exact final head, d3bafe1, passed the full Rust suite, Clippy, formatting, site and Console checks.scripts/affected-tests ac8d24494e52f42268e524f716be20e4f71af361passed all 43 site checks. Its duplicate Rust run was stopped after exact-head CI passed, reusing that result asdocs/testing.mddirects.Merge Danger
Door: two-way
Blast Radius: Evals
Enables Code review Trials and completes missing private replay-manifest inputs. Existing custom Trial tables and grading criteria are preserved.
Test seams
--trialprotocol against fake Harnesses: the Code review prompt, reviewer independence, and retained reports.evals import-replays,experiment, andexperiments --jsoninterfaces against fake Harnesses: imported and prepared review inputs, preservation of local edits on reimport, three Trials per Arm, and pass^3.Review coverage
Reviewed against the updated
issue-977head, pinned atac8d24494e52f42268e524f716be20e4f71af361, after merging its Void Trial changes into this branch. Fresh independent reviewers inspected the reconciled diff and the final fixture cleanup.Unaddressed findings
Built with codex · gpt-6.1-sol · xhigh