Repository navigation
Replace raw Session logs with Session traces - #1134
Merged
Merged
Conversation
This was referenced Oct 23, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Retires raw Session-log readers, the Waterfall's Command-log matcher and the one-time converter. Updates the glossary, guide, README and Session prompts, with generated pages refreshed.
Malformed Harness bytes are retained in OTLP byte bodies and displayed as escaped diagnostics.
Closes #997
Evidence
cargo test --test session_traces all_six_harnesses_leave_one_inventory_entry_and_both_otlp_filesfailed because the raw file still existed.After: the same test passed for all six Harnesses, checking trace files, Model evidence and Command-record paths.
cargo run --quiet --bin thirdshift -- logs --convertexited 2 while the guide advertised it; the review's documentation assertion failed.After: the retired tutorial is removed, HTML regenerated, and the regression in
node --test site/tests/docs.test.cjspasses.Test seams: Session artifacts; CLI/Console trace consumers, live tails and Silent observations; generated documentation and prompts.
Validation completed across the repository selector and its continuation:
scripts/affected-tests issue-700-branch-2passed site checks, all 1,242 unit tests and the earlier integration targets, then exposed an obsolete export fixture. After correcting that fixture,cargo test --no-fail-fastforexport_traceand every remaining integration target passed. All 56 integration targets are covered, with 1,106 tests passed and no remaining failures.cargo clippy --all-targets -- -D warningsand all 59 Console browser tests passed. Focused trace, malformed-byte, Grok, recording and prompt-assertion checks passed. Rust, Console, site and release-build CI checks are green.Review coverage
Standards: all three maintenance findings addressed. Spec: the P2 documentation finding addressed. Final independent review also covers malformed-byte preservation and trace fixture assertions. Aggregate coverage on each axis is all 112 changed paths, including deleted contents and generated hunks. No changed file was left unread or excluded.
Unaddressed findings
Security review outcome
No unaddressed introduced findings.
Merge Danger
Door: two-way
Blast Radius: logging
Session artifacts and CLI/Console history, live observations and Waterfall rendering. Hosts' histories were converted in #994; raw-only Session logs are no longer read.
Built with codex · gpt-6.1-sol · xhigh