Skip to content

Replace raw Session logs with Session traces - #1134

Merged
JacobStephens2 merged 5 commits into
issue-700-branch-2from
issue-997
Oct 23, 2026
Merged

JacobStephens2 merged 5 commits into
issue-700-branch-2from
issue-997

Conversation

@JacobStephens2

@JacobStephens2 JacobStephens2 commented Oct 23, 2026 •

Copy link
Copy Markdown
Owner

Summary

 Session artifacts
-<session>.jsonl                  raw Harness stream
 <session>.logs.jsonl             streaming OTLP log records
 <session>.spans.jsonl            Session, model and tool spans
 <session>.models.json
 <session>.standards / <session>.spec

 Command record
-session_log = <session>.jsonl
+session_log = <session>.logs.jsonl

Retires raw Session-log readers, the Waterfall's Command-log matcher and the one-time converter. Updates the glossary, guide, README and Session prompts, with generated pages refreshed.

Malformed Harness bytes are retained in OTLP byte bodies and displayed as escaped diagnostics.

Closes #997

Evidence

  • Before: cargo test --test session_traces all_six_harnesses_leave_one_inventory_entry_and_both_otlp_files failed because the raw file still existed.
    After: the same test passed for all six Harnesses, checking trace files, Model evidence and Command-record paths.
  • Before: the review's cargo run --quiet --bin thirdshift -- logs --convert exited 2 while the guide advertised it; the review's documentation assertion failed.
    After: the retired tutorial is removed, HTML regenerated, and the regression in node --test site/tests/docs.test.cjs passes.

Test seams: Session artifacts; CLI/Console trace consumers, live tails and Silent observations; generated documentation and prompts.

Validation completed across the repository selector and its continuation: scripts/affected-tests issue-700-branch-2 passed site checks, all 1,242 unit tests and the earlier integration targets, then exposed an obsolete export fixture. After correcting that fixture, cargo test --no-fail-fast for export_trace and every remaining integration target passed. All 56 integration targets are covered, with 1,106 tests passed and no remaining failures.

cargo clippy --all-targets -- -D warnings and all 59 Console browser tests passed. Focused trace, malformed-byte, Grok, recording and prompt-assertion checks passed. Rust, Console, site and release-build CI checks are green.

Review coverage

Standards: all three maintenance findings addressed. Spec: the P2 documentation finding addressed. Final independent review also covers malformed-byte preservation and trace fixture assertions. Aggregate coverage on each axis is all 112 changed paths, including deleted contents and generated hunks. No changed file was left unread or excluded.

Unaddressed findings

  • Standards: None.
  • Spec: None.
  • Security: None.

Security review outcome

No unaddressed introduced findings.

Merge Danger

Door: two-way

Blast Radius: logging

Session artifacts and CLI/Console history, live observations and Waterfall rendering. Hosts' histories were converted in #994; raw-only Session logs are no longer read.

Built with codex · gpt-6.1-sol · xhigh

@JacobStephens2
JacobStephens2 merged commit 0d6b85d into issue-700-branch-2 Oct 23, 2026
18 checks passed
@JacobStephens2
JacobStephens2 deleted the issue-997 branch October 23, 2026 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant