Repository navigation
Cache Arm builds and record fixed Harness paths - #1124
Merged
Merged
Conversation
This was referenced Oct 23, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Prepare both Arms before Trials, caching thirdshift by commit and recording each Harness's real path and version.
Adds
thirdshift evals prepare-armsand documents the record and cache layout. Git replacement objects cannot change the requested build. Trial execution and Experiment scheduling remain in #1001 and #1003; this change supplies their preparation inputs.Closes #1002
Evidence
seeded_arm_commits_are_recorded_without_buildingfailed because the preparation command was absent. A stderr-only Harness version failed as empty; a Git replacement built the candidate twice.After:
cargo test --test eval_armspasses all 7 tests, including those regressions, failed-build cleanup, concurrent cache reuse, distinct Harness versions and a link swapped between Arm launches.cargo clippy --all-targets -- -D warningsandcargo fmt --checkpass./usr/bin/time -p scripts/affected-tests origin/issue-977passes: 43 site tests and 2,392 Rust tests passed, with 56 Rust tests skipped by the repository configuration. Total wall time was 1,595.25 s including compilation and site checks; Rust compilation took 1m 30s, and Nextest execution took 1,447.242 s (11 slow tests).0623ff0.Test seam: the whole binary with real Git repositories, seeded test binaries, and fake Cargo/Harness executables. Assertions inspect JSON output, the saved Arm record and the executable at its recorded path. The link-swap test invokes that path directly; production Trial integration belongs to #1001/#1003. Tests compile no Arm builds.
Review coverage
Used
thirdshift-code-reviewwithissue-977pinned to its fetched headcea6615b2e039e1521d6b0e62e6abfb4668c3c1a. Standards: 0 findings. Spec: 0 findings.Both reviewers read all 8 changed files. Unread changed files: none. Generated exclusions: none; generated manual changes were inspected. Final reports and each axis's files-read list are saved in
.thirdshift-review-jwdqiI/standards.mdand.thirdshift-review-jwdqiI/spec.mdin the worktree.Unaddressed findings
Standards
None.
Spec
None.
Merge Danger
Door: two-way
Blast Radius: Evals
Adds build-cache entries and a new Arm record.
Built with codex · gpt-6.1-sol · xhigh