Repository navigation
Add hidden Trial flag for Spec review sessions - #1121
Merged
Merged
Conversation
This was referenced Oct 23, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Uses the existing Session prompt and Factory skills without a Command record.
The protocol and caller preparation requirements are documented in
docs/trial.md.Code review remains the follow-up in #1016.
Closes #1001
Test seams
thirdshift --trial <request.json>CLI, with a prepared repository and fake Harness executables: version rejection, outcome and timings, session ID, Model/Effort, report preservation, Resume and interruption; filesystem observations verify factory-log isolation, output reuse protection and cleanup.Evidence
not a GitHub issue URL: --trial; focused regressions exposed missing failed-session IDs, inherited ownership and leftover Factory-skill temporary files.After:
cargo test --test trialpasses all 11 Trial tests (one fixture entry point ignored), including Claude and Codex, both reports, unknown versions, Void causes, interruption and exactly one Resume.session_id: nullafter an observed Harness ID and interruption.After:
cargo test --test trial an_interrupted_trial_keeps_an_already_observed_session_id -- --exactpasses and returnsfake-session-1; the regression is retained.cargo test --test background_work: 4 passed, one fixture entry point ignored.cargo check: passed.scripts/affected-tests issue-977passed all 43 browser checks. Its duplicate local full Rust run was stopped after successful CI covered the exact same head, asdocs/testing.mdpermits; Rust test-binary compilation took 3m 41s. No local full-suite completion is claimed.772251c; site and Console checks also passed. The initial Linux attempt hitExecutableFileBusystarting a copied binary in the unchanged Console-install fixture. Its exact test passed locally, and the failed job passed on retry without code changes.Merge Danger
Door: two-way
Blast Radius: sessions
Shared session storage now distinguishes an ownerless Trial from a failed Command-log allocation. Failed Harness sessions retain their ID; normal Run launch and Resume policy use the same implementation.
Review coverage
Independent Standards and Spec reviews used
issue-977atd05aa971f1e050efbc88744404c75d1433d9d5c4. Standards S1 (typed protocol states) and Spec P1 (interrupted-session ID) were addressed in772251cand confirmed in follow-up reviews.Both axes read all 11 changed files. Unread changed files: none under Standards and none under Spec. Generated-output exclusions: none.
Unaddressed findings
Built with codex · gpt-6.1-sol · xhigh