Repository navigation
Add private Eval task format and time-safe repositories - #1120
Merged
Merged
Conversation
This was referenced Oct 23, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add versioned private Eval task/suite manifests, dependency selection and throwaway repositories that expose only base history. Proposed Eval tasks are listed and refused preparation. Spec-review repositories get a pushable local bare origin.
The format is documented with invented data; no real Eval tasks are checked in. This adds preparation commands, not the Experiment runner or approval workflow.
Closes #1000
Evidence
evalswas unsupported. Independent Spec reproductions also failed fordiff.noprefix=true,diff.context=0, and a silently dropped submodule commit update.After: all nine
cargo test --test evalstests pass. All three exact reviewer reproduction commands pass after fixes, with their Rust regressions retained. Tests exercise base-only history and absent future objects, a planted later ref, a real push to the bare origin, all five dependency categories, and proposal refusal.cargo check,cargo clippy --all-targets -- -D warnings, andgit diff --checkpass. Final validation also exposed the existing 65-line help limit; the compact entry fixes it, andcargo test --test command_surfacepasses (20 tests, one fixture entry point ignored).scripts/affected-tests issue-977run passed all 43 site/browser checks. Its duplicate local Rust phase was stopped when CI run 39887910032 passed on exact head860b3293aafbbd2c081d9ee67bc0c12e80cf6a7d, following the repository's CI-reuse policy. That run passed fullcargo test, formatting, all-target clippy, Console tests and Site tests.Test seams
thirdshift evals listandtouched: private manifest loading, proposal exclusion and dependency selection.thirdshift evals prepare: time-safe Git history, reviewed changes, task inputs and a pushable Spec-review origin.thirdshift evals verify: the history check preparation uses, including a planted later commit.Review
Reviewed against
issue-977using independent Standards and Spec reviewers. Addressed the Standards fixture Message Chains judgment call and both Spec findings, including the follow-up context-setting reproduction. Every behavioral reproduction was run as written before accepting its finding. Reports retain initial/follow-up findings and each axis's final files-read list.Both reviewers read all 12 changed files, including generated
site/docs/index.html. The final compact-help correction insrc/main.rswas added after their follow-ups and remains unread by those reviewers; its existing command-surface tests pass. No other changed content remains unread. Generated-output exclusions: none.Unaddressed findings
Standards
None.
Spec
None.
Merge Danger
Door: two-way
Additive CLI and private format; preparation requires a new destination and leaves source repositories unchanged. Prepared repositories are disposable.
Blast Radius: Evals
Built with codex · gpt-6.1-sol · xhigh