Skip to content

Check Console DNS before proxy installation - #1071

Merged
JacobStephens2 merged 2 commits into
mainfrom
issue-945
Oct 22, 2026
Merged

JacobStephens2 merged 2 commits into
mainfrom
issue-945

Conversation

@JacobStephens2

@JacobStephens2 JacobStephens2 commented Oct 22, 2026 •

Copy link
Copy Markdown
Owner

Summary

console install script (Caddy / Apache)
  resolve the Console address
    missing: explain how to add DNS, exit before changes
    found: install the service and proxy as before

Closes #945

Evidence

  • Before: cargo test --test console_install unresolved_console_address_stops_proxy_installation_before_any_changes -- --exact failed with caddy installed without DNS.
    After: the same command passes, covering Caddy and both Apache layouts. Script execution verifies that failed resolution stops before unit/site writes or service changes. IPv4 and IPv6 resolver successes complete installation.
  • cargo test --test console_install: 15 passed. An initial run hit Text file busy in the existing binary-copy test; the unchanged test file passed on rerun.
  • cargo check --all-targets, cargo fmt --all -- --check, and cargo clippy --all-targets -- -D warnings: passed.
  • /usr/bin/time -p scripts/affected-tests main: passed, including all 36 site checks and the full Rust suite (cargo nextest run: 2,251 passed, 51 skipped). Wall time: 1,481.67 seconds, including site checks and compilation. Rust test execution: 1,316.512 seconds; test compilation: 1 minute 37 seconds.

Seams under test: thirdshift console install and execution of its printed shell script, with system commands stubbed and /etc writes redirected into the fixture.

Review coverage

Independent Standards and Spec reviews against main: zero findings on each axis. Both reviewed all five changed files, including the generated HTML. Unread changed files: none. Generated-output exclusions: none.

Unaddressed findings

  • Standards: none.
  • Spec: none.
  • Security: none.

Security review outcome

No unaddressed introduced findings.

Merge Danger

Door: two-way

Blast Radius: Console

Built with codex · gpt-6.1-sol · xhigh

@JacobStephens2
JacobStephens2 merged commit c3afe05 into main Oct 22, 2026
18 checks passed
@JacobStephens2
JacobStephens2 deleted the issue-945 branch October 22, 2026 13:21
@JacobStephens2 JacobStephens2 mentioned this pull request Oct 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

console install: check the Console's address resolves before requesting a certificate

1 participant