Repository navigation
Check Console DNS before proxy installation - #1071
Merged
Merged
Conversation
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #945
Evidence
cargo test --test console_install unresolved_console_address_stops_proxy_installation_before_any_changes -- --exactfailed withcaddy installed without DNS.After: the same command passes, covering Caddy and both Apache layouts. Script execution verifies that failed resolution stops before unit/site writes or service changes. IPv4 and IPv6 resolver successes complete installation.
cargo test --test console_install: 15 passed. An initial run hitText file busyin the existing binary-copy test; the unchanged test file passed on rerun.cargo check --all-targets,cargo fmt --all -- --check, andcargo clippy --all-targets -- -D warnings: passed./usr/bin/time -p scripts/affected-tests main: passed, including all 36 site checks and the full Rust suite (cargo nextest run: 2,251 passed, 51 skipped). Wall time: 1,481.67 seconds, including site checks and compilation. Rust test execution: 1,316.512 seconds; test compilation: 1 minute 37 seconds.Seams under test:
thirdshift console installand execution of its printed shell script, with system commands stubbed and/etcwrites redirected into the fixture.Review coverage
Independent Standards and Spec reviews against
main: zero findings on each axis. Both reviewed all five changed files, including the generated HTML. Unread changed files: none. Generated-output exclusions: none.Unaddressed findings
Security review outcome
No unaddressed introduced findings.
Merge Danger
Door: two-way
Blast Radius: Console
Built with codex · gpt-6.1-sol · xhigh