Repository navigation
Skip git hooks for Pickup reservation pushes - #1066
Merged
Merged
Conversation
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Pickup reservation creation and release skip the Launch directory's git hooks.
The reservation's leases, parentless token and fail-closed handling stay intact.
Closes #847
Evidence
Test seam: the
thirdshift pickupCLI against a real local Git origin, with a rejecting Launch directorypre-pushhook; observe dispatch and the reservation ref through Git.cargo test --test pickup_run a_rejecting_pre_push_hook_does_not_block_reserving_or_releasing_a_ready_issue -- --exactfailed on the original code before dispatch (no PR from issue-7: []). With only creation fixed, the same command failed because the rejecting hook blocked release and leftrefs/heads/thirdshift/pickup/7on origin.After: With both pushes fixed,
cargo test --test pickup_runpassed: 89 tests, 1 ignored fixture entry. This includes the new regression and the unchanged race, stale-selection and uncertain-outcome tests.cargo check --all-targets,cargo fmt --checkandgit diff --checkpassed.e9301bc, including Linux, macOS, site and Console and release builds and smoke checks./usr/bin/time -p scripts/affected-tests mainselectedcargo nextest runand passed: 2,242 tests, 0 failures, 50 skipped, 7 slow. Wall time: 1,206.23 seconds (20m 6s), including compilation; test execution: 1,134.734 seconds. Compilation was included (Cargo reported 1m 10s).Merge Danger
Door: two-way
Blast Radius: Pickup
Only local hooks on reservation creation and release are skipped. The change is easy to revert; remote repository rules still apply.
Unaddressed findings
Security review outcome
No unaddressed introduced findings.
Review coverage
Independent Standards and Spec reviews used
git diff main...HEADwithmainata61aa02. Both reviewers read every changed file:src/pickup/reservation.rsandtests/pickup_run.rs.Changed files left unread: none under either axis. Generated-output exclusions: none.
Built with codex · gpt-6.1-sol · xhigh