Skip to content

Skip git hooks for Pickup reservation pushes - #1066

Merged
JacobStephens2 merged 1 commit into
mainfrom
issue-847
Oct 22, 2026
Merged

JacobStephens2 merged 1 commit into
mainfrom
issue-847

Conversation

@JacobStephens2

@JacobStephens2 JacobStephens2 commented Oct 22, 2026 •

Copy link
Copy Markdown
Owner

Summary

Pickup reservation creation and release skip the Launch directory's git hooks.

- git push --force-with-lease=<ref>: origin <token>:<ref>
+ git push --no-verify --force-with-lease=<ref>: origin <token>:<ref>
- git push --force-with-lease=<ref>:<token> origin :<ref>
+ git push --no-verify --force-with-lease=<ref>:<token> origin :<ref>

The reservation's leases, parentless token and fail-closed handling stay intact.

Closes #847

Evidence

Test seam: the thirdshift pickup CLI against a real local Git origin, with a rejecting Launch directory pre-push hook; observe dispatch and the reservation ref through Git.

  • Before: cargo test --test pickup_run a_rejecting_pre_push_hook_does_not_block_reserving_or_releasing_a_ready_issue -- --exact failed on the original code before dispatch (no PR from issue-7: []). With only creation fixed, the same command failed because the rejecting hook blocked release and left refs/heads/thirdshift/pickup/7 on origin.
    After: With both pushes fixed, cargo test --test pickup_run passed: 89 tests, 1 ignored fixture entry. This includes the new regression and the unchanged race, stale-selection and uncertain-outcome tests.
  • cargo check --all-targets, cargo fmt --check and git diff --check passed.
  • All CI checks passed for e9301bc, including Linux, macOS, site and Console and release builds and smoke checks.
  • Full validation: /usr/bin/time -p scripts/affected-tests main selected cargo nextest run and passed: 2,242 tests, 0 failures, 50 skipped, 7 slow. Wall time: 1,206.23 seconds (20m 6s), including compilation; test execution: 1,134.734 seconds. Compilation was included (Cargo reported 1m 10s).

Merge Danger

Door: two-way

Blast Radius: Pickup

Only local hooks on reservation creation and release are skipped. The change is easy to revert; remote repository rules still apply.

Unaddressed findings

  • Standards: none; 0 findings.
  • Spec: none; 0 findings.

Security review outcome

No unaddressed introduced findings.

Review coverage

Independent Standards and Spec reviews used git diff main...HEAD with main at a61aa02. Both reviewers read every changed file: src/pickup/reservation.rs and tests/pickup_run.rs.

Changed files left unread: none under either axis. Generated-output exclusions: none.

Built with codex · gpt-6.1-sol · xhigh

@JacobStephens2
JacobStephens2 merged commit 25ec54b into main Oct 22, 2026
18 checks passed
@JacobStephens2
JacobStephens2 deleted the issue-847 branch October 22, 2026 11:08
@JacobStephens2 JacobStephens2 mentioned this pull request Oct 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Pickup reservation pushes run the repository's git hooks

1 participant