Repository navigation
Name the issues holding Pickup at its Claim limit - #1065
Merged
Merged
Conversation
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Pickup names every issue holding its Claim limit in ascending order, using the existing Claims read.
Repeated holders keep one Activity log line; a changed holder set writes another and appears as the latest idle-Pass reason in status.
Closes #787
Evidence
cargo test --test pickup_run a_claim_limit_skip_names_every_holder_lowest_first_without_extra_github_requests -- --exactfailed with the old count-only reason.After: The same test passes and asserts exactly the existing closed/open
in-progressissue-list requests.cargo test --test pickup_run --test activity_log: 100 passed, two fixture entry points ignored. Covers single and multiple holders, the configured limit, unchanged-holder deduplication, changed holders at the same count, and the latest idle-Pass reason in status.cargo check --all-targets: passed./usr/bin/time -p scripts/affected-tests main: passed viacargo nextest run; 2,241 passed, 50 skipped. Test execution: 1,133.431s; total wall time: 1,199.01s (19m 59s), including test-target compilation (64s). The separate site check below covers the manual-only follow-up added while Rust validation was running.cargo fmt --checkandcargo clippy --all-targets -- -D warnings: passed.docs/guide.mdand regeneratedsite/docs/index.htmlwithnpm run docs --prefix site.npm test --prefix site: 36 browser tests passed, including the generated-manual freshness check.4cb19bb, including the Linux Rust suite, macOS gate, Console tests, site tests, and platform builds.Test seams
thirdshift pickupthrough the integration Scenario and fakegh: stderr's skip reason and the recorded GitHub requests.thirdshift pickupacross invocations: the repository's Activity log andthirdshift status's latest idle-Pass reason.Unaddressed findings
Security review outcome
No unaddressed introduced findings.
Review coverage
Independent Standards and Spec reviews use
main(c3dcc8f) as their fixed point and cover final head4cb19bb. Both axes read every changed file:src/pickup.rs,tests/pickup_run.rs,tests/activity_log.rs,docs/guide.md, andsite/docs/index.html. The documentation observation was addressed and reviewed in one follow-up per axis. Standards: 0 findings. Spec: 0 findings. Unread changed files: none. Generated-output exclusions: none; both reviewers inspected the generated HTML change directly.Merge Danger
Door: two-way
The change can be reverted without a migration.
Blast Radius: Pickup
Changes the Claim-limit skip reason shown on stderr, in the Activity log, and by idle-Pass readers in status and the Console.
Built with codex · gpt-6.1-sol · xhigh