Skip to content

Name the issues holding Pickup at its Claim limit - #1065

Merged
JacobStephens2 merged 2 commits into
mainfrom
issue-787
Oct 22, 2026
Merged

JacobStephens2 merged 2 commits into
mainfrom
issue-787

Conversation

@JacobStephens2

@JacobStephens2 JacobStephens2 commented Oct 22, 2026 •

Copy link
Copy Markdown
Owner

Summary

Pickup names every issue holding its Claim limit in ascending order, using the existing Claims read.

- at the Claim limit on acme/widgets: 3 open issue(s) labelled in-progress, pickup.limit is 3
+ at the Claim limit on acme/widgets: #924, #936 and #953 are labelled in-progress, pickup.limit is 3

Repeated holders keep one Activity log line; a changed holder set writes another and appears as the latest idle-Pass reason in status.

Closes #787

Evidence

  • Before: cargo test --test pickup_run a_claim_limit_skip_names_every_holder_lowest_first_without_extra_github_requests -- --exact failed with the old count-only reason.
    After: The same test passes and asserts exactly the existing closed/open in-progress issue-list requests.
  • cargo test --test pickup_run --test activity_log: 100 passed, two fixture entry points ignored. Covers single and multiple holders, the configured limit, unchanged-holder deduplication, changed holders at the same count, and the latest idle-Pass reason in status.
  • cargo check --all-targets: passed.
  • /usr/bin/time -p scripts/affected-tests main: passed via cargo nextest run; 2,241 passed, 50 skipped. Test execution: 1,133.431s; total wall time: 1,199.01s (19m 59s), including test-target compilation (64s). The separate site check below covers the manual-only follow-up added while Rust validation was running.
  • cargo fmt --check and cargo clippy --all-targets -- -D warnings: passed.
  • Updated docs/guide.md and regenerated site/docs/index.html with npm run docs --prefix site. npm test --prefix site: 36 browser tests passed, including the generated-manual freshness check.
  • All GitHub checks passed at 4cb19bb, including the Linux Rust suite, macOS gate, Console tests, site tests, and platform builds.

Test seams

  • thirdshift pickup through the integration Scenario and fake gh: stderr's skip reason and the recorded GitHub requests.
  • thirdshift pickup across invocations: the repository's Activity log and thirdshift status's latest idle-Pass reason.

Unaddressed findings

  • Standards: None; no findings were skipped.
  • Spec: None; no findings were skipped.
  • Security: None. The guidance review found no introduced finding.

Security review outcome

No unaddressed introduced findings.

Review coverage

Independent Standards and Spec reviews use main (c3dcc8f) as their fixed point and cover final head 4cb19bb. Both axes read every changed file: src/pickup.rs, tests/pickup_run.rs, tests/activity_log.rs, docs/guide.md, and site/docs/index.html. The documentation observation was addressed and reviewed in one follow-up per axis. Standards: 0 findings. Spec: 0 findings. Unread changed files: none. Generated-output exclusions: none; both reviewers inspected the generated HTML change directly.

Merge Danger

Door: two-way

The change can be reverted without a migration.

Blast Radius: Pickup

Changes the Claim-limit skip reason shown on stderr, in the Activity log, and by idle-Pass readers in status and the Console.

Built with codex · gpt-6.1-sol · xhigh

@JacobStephens2
JacobStephens2 merged commit a61aa02 into main Oct 22, 2026
18 checks passed
@JacobStephens2
JacobStephens2 deleted the issue-787 branch October 22, 2026 10:34
@JacobStephens2 JacobStephens2 mentioned this pull request Oct 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Name the Claims holding Pickup at its Claim limit, and tell the Day shift once

1 participant