Skip to content

Render all six Harnesses in the conversation view - #1059

Merged
JacobStephens2 merged 4 commits into
issue-700from
issue-990
Oct 22, 2026
Merged

JacobStephens2 merged 4 commits into
issue-700from
issue-990

Conversation

@JacobStephens2

@JacobStephens2 JacobStephens2 commented Oct 22, 2026 •

Copy link
Copy Markdown
Owner

Summary

Claude · Codex · agy · Grok Build · Muse Code · OpenCode
  Session-trace records
    → normalized messages, tool calls and results
    → one current snapshot per scoped message ID, including live updates
    → escaped raw output for unfamiliar events

Closes #990

Test seams

  • Console HTTP log reader and appended-line stream, with on-disk Session-trace fixtures.
  • Console browser conversation: message identity across streamed snapshots and reload.

Evidence

  • Before: The six-Harness regression rendered the raw body instead of normalized messages. Both review reproductions failed: Muse/OpenCode showed two snapshots as two replies; normalized Codex reasoning lost Thinking.
    After: All six fixtures render messages, tools and results; unknown events preserve the rest of the conversation. Snapshot reproductions show one current reply, and Codex reasoning remains collapsed.
  • Rust Console integration tests pass, including the six-Harness and appended raw-block regressions; the complete CI run below includes 51 Console tests against the current base.
  • python3 console/reproductions/conversation-traces.py snapshots and reasoning: passed. Original reviewer commands were run before deciding their findings, and both failed as reported.
  • npm test --prefix console: 48 passed, 1 intentional skip (normalized snapshots do not apply to old raw Session logs). After CI caught an existing SSE test accessing its injected source before initialization, a one-line readiness wait was added and the full browser suite passed.
  • cargo clippy --all-targets -- -D warnings, cargo fmt --check, and git diff --check: passed.
  • Full Rust suite: CI cargo test passed 2,288 tests, with 3 ignored, across 53 binaries for head d5e8357 against the current base. The step took 603 s, including a 33.10 s build. Console, site, formatting, Clippy, and all other applicable checks are green.
  • Local /usr/bin/time -p scripts/affected-tests c70337edc34a35048a73ca41b2cd10561e838069 initially passed 230 tests before an authentication request exceeded its 10-second client timeout (632.07 s wall time, including compilation). The exact failed test passed in isolation. A two-worker full retry was stopped after the successful exact-head CI result, as docs/testing.md directs; it reported no failures before stopping. Authentication code was not changed for the timeout.

Review coverage

Reviewed against issue-700, pinned to c70337edc34a35048a73ca41b2cd10561e838069 at the start of review. Standards: both P3 findings addressed. Spec: both P2 findings reproduced and fixed, with regression coverage retained. Both axes read all 16 changed files; no generated-output exclusions and no unread changed files.

The final one-line CI readiness wait in console/tests/logs.test.cjs was added after both reviewers' final pass at af4ef0f; that new line was checked by the parent and validated by the full browser suite. Both axes had read the file before this adjustment.

Merge Danger

Door: two-way

Blast Radius: Console

Affects initial and streamed Session conversations.

Unaddressed findings

  • Standards: None.
  • Spec: None.

Built with codex · gpt-6.1-sol · xhigh

@JacobStephens2
JacobStephens2 merged commit 0ef17c4 into issue-700 Oct 22, 2026
18 checks passed
@JacobStephens2
JacobStephens2 deleted the issue-990 branch October 22, 2026 05:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant