Repository navigation
Export a Command's whole Trace as local OTLP JSON Lines - #1058
Merged
Merged
Conversation
This was referenced Oct 22, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Exports one complete local Trace, including child Runs, with the Command record's times. Adds CLI help and guide documentation. Nothing is sent anywhere.
Closes #991
Evidence
cargo test --test export_trace trace_only_sessions_export_once_even_when_the_record_names_the_old_logfailed withduplicate span ID in Trace.After: normalizing Session paths before deduplication passes the regression.
help_is_a_compact_reference_with_a_link_to_the_detailsfailing at 66 lines.After: advertising export on the existing
logsrow passescargo test --test command_surface help_is_a_compact_reference_with_a_link_to_the_details; the 65-line limit remains intact.cargo check, formatting, and guide generation checks pass. The Linux CI job passed the full Rust suite and clippy with warnings denied on exact headceb23e0(9m24s job execution, including setup and compilation)./usr/bin/time -p scripts/affected-tests origin/issue-700passed all 36 site browser tests locally. Followingdocs/testing.md, its duplicate Rust run was stopped once the exact-head CI suite passed: 710.21s local wall time, including 18.37s Rust compilation. This interrupted local Rust run is not counted as a passing suite.Test seams
thirdshift logs <command> --export <dir>CLI and its two exported OTLP JSON Lines files, decoded with OpenTelemetry's official types; retainedshow --jsonobservations provide Command record times and child ownership.Review coverage
Independent Standards and Spec reviews use
issue-700at upstream commitf21fc0072493ac62563c2ea2d2620f4b8c1e5a92(the local checkout of that branch was older). Both read all nine changed files, includingsite/docs/index.html; no generated exclusions or unread changed files. Standards raised one P3 test-duplication judgment, resolved and verified in170c237. Spec found no issues. Reports are retained in.thirdshift-review-hW56iY/standards.mdandspec.mdwith each axis's final files-read list.The coordinator checked the later help-text correction in
src/main.rs(ceb23e0) against the existing compact-help regression test.Unaddressed findings
Standards
None. The single finding was addressed.
Spec
None.
Merge Danger
Door: two-way
Blast Radius: logs
Adds an explicit local export operation. Existing export files are refused. Incomplete ancestry or malformed Session trace requests fail before publication.
Built with codex · gpt-6.1-sol · xhigh