Repository navigation
Use Session trace spans for Waterfall tool times - #1056
Merged
Merged
Conversation
This was referenced Oct 22, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Preserve overlapping calls and fractional timestamps across Harnesses. For died Commands, size the historical axis from retained trace times so completed tool bars remain visible.
Closes #989
Test seams
Evidence
After:
cargo test --test console waterfall_passes all 5 tests, including span times, scoped running records, incomplete live tails, sub-millisecond precision and legacy Claude/Codex matching.After: the same test, retained as
python3 console/reproductions/waterfall-trace-axis.py, passes with visible completed bars and unchanged measured durations.node --test console/tests/waterfall.test.cjs: 2 tests pass at 1200 px and 390 px, covering overlapping measured bars, live start records, died Commands and legacy matching.cargo check --all-targets,cargo clippy --all-targets -- -D warnings, andcargo fmt --checkpass./usr/bin/time -p scripts/affected-tests origin/issue-700selectedcargo nextest run: 2,278 tests passed, 3 skipped, across 53 binaries. Wall time: 2,362.83 seconds (39m 23s), including 24.95 seconds of incremental compilation.Review coverage
Independent Standards and Spec reviews used fetched
issue-700atd56453d5541b879cd04a4f202aa2937dc14ba3d6. Both reviewers read all 12 changed files, including the retained reproduction added during fixes. Unread changed files: none. Generated-output exclusions: none.Merge Danger
Door: two-way
Read-only Console rendering change; no stored-data migration.
Blast Radius: Console
Unaddressed findings
Standards
None. The optional repeated fixture setup finding was addressed with shared retained-Command and Console-start helpers.
Spec
None. The P2 died-Command axis finding was reproduced with the reviewer's exact command, fixed, and retained as an HTTP reproduction plus browser regression.
Built with codex · gpt-6.1-sol · xhigh