Skip to content

Read Session traces in the Console and show - #1053

Merged
JacobStephens2 merged 2 commits into
issue-700from
issue-987
Oct 22, 2026
Merged

JacobStephens2 merged 2 commits into
issue-700from
issue-987

Conversation

@JacobStephens2

@JacobStephens2 JacobStephens2 commented Oct 22, 2026 •

Copy link
Copy Markdown
Owner

Summary

Session reference
  -> prefer Session trace log records; fall back to old Session log
      -> Console conversation / byte-offset stream
      -> show's latest live event
      -> Silent / heartbeat observations

Closes #987.

Evidence

  • Before: the conversation regression rendered the stale Session log; show reported Bash: stale command; a trace-only live session lost its live status; Silent and heartbeat ignored log-record growth.
    After: the same focused regressions pass for Claude and Codex conversations, latest events, all three browser storage modes, Silent and heartbeat.
  • cargo test --test console: 46 passed; cargo test --test show_logs: 15 passed; cargo test --test run_health: 5 passed.
  • npm test --prefix console: 46 passed, including append/reconnect/polling under old logs, dual recording and trace-only recording.
  • Review regression: cargo test --test show_logs show_keeps_the_latest_event_when_otlp_escaping_expands_a_record_past_64_kib failed before the fix and passes afterward (80 KiB and 320 KiB encoded requests). The reviewer's exact reproduction also changed from failure to success.
  • cargo fmt --check and cargo clippy --all-targets -- -D warnings pass on the final commit.
  • Full Rust suite: CI test passed on final head d5349ba.
  • Local /usr/bin/time -p scripts/affected-tests d56453d5541b879cd04a4f202aa2937dc14ba3d6 selected cargo nextest run. Per docs/testing.md, stopped this duplicate after exact-head CI passed: 996.11 seconds elapsed including compilation, 396 tests passed before cancellation, 4 interrupted, 3 skipped. This was an interrupted run, not a completed local full-suite result.

Test seams

  • Console HTTP log inventory, conversation reader and byte-offset stream.
  • show / show --json and status --json CLI observations.
  • Console browser conversation append/reconnect and Inbox heartbeat.

Review

Independent Standards and Spec reviews use the fetched issue-700 fixed point, d56453d5541b879cd04a4f202aa2937dc14ba3d6.

Standards: 0 findings. Spec: 1 P2 finding, reproduced and fixed by reading a complete OTLP request across the tail window; regression retained. Both reviewers checked the final fix.

Changed files left unread: none under either axis (15/15 files read by each reviewer). Generated-output exclusions: none.

Unaddressed findings

Standards

None.

Spec

None. The large-record latest-event finding was addressed.

Merge Danger

Door: two-way

Reader changes can be reverted; retained Session logs and Session traces stay intact.

Blast Radius: readers

Console log inventory, conversations and streams; latest live events in show; Silent and heartbeat observations.

Built with codex · gpt-6.1-sol · xhigh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant