Skip to content

Record Harness versions in Session trace resources - #1052

Merged
JacobStephens2 merged 4 commits into
issue-700from
issue-986
Oct 22, 2026
Merged

JacobStephens2 merged 4 commits into
issue-700from
issue-986

Conversation

@JacobStephens2

@JacobStephens2 JacobStephens2 commented Oct 22, 2026 •

Copy link
Copy Markdown
Owner

Summary

Each Session trace records thirdshift.harness.version for all six Harnesses.

Session trace resource
  Harness stream version
  else Command/Harness cache shared by child Runs
    <Harness> --version
    empty or failed lookup → unknown

Closes #986

Evidence

  • Before: cargo test --test session_traces all_six_harnesses_record_their_version_in_session_trace_resources failed because Codex's resource had no thirdshift.harness.version.
    After: the regression passes for all six Harnesses; cargo test --test session_traces passes all 8 tests, including parallel Tickets, separate Commands, unknown versions, stream precedence and a separate Security review Harness.
  • Before: Session-execution fixtures interpreted --version as another Session, and log-list checks included the new cache artifacts.
    After: the fixtures answer version queries separately; all 10 cargo test --bin thirdshift session::execution_tests tests and all 12 cargo test --test command_logs tests pass, preserving their behavior assertions.
  • cargo check passed locally. cargo fmt --check and cargo clippy --all-targets -- -D warnings also passed in CI for final head 6c8d122.
  • Final local validation: scripts/affected-tests origin/issue-700 ran cargo nextest run: 2,280 passed, 3 skipped. /usr/bin/time -p scripts/affected-tests origin/issue-700 measured 2,313.88 s wall (build step included; cached build took 0.93 s). CI also passed for final head 6c8d122.

Test seams

  • The compiled thirdshift CLI with real Git and fake Harness executables, observing Session trace resources and version-command invocations across Sessions and child Runs.
  • Sessions::within with executable CLI fixtures, observing process cleanup, retained reporting, and prompt transport after execution failures.

Review coverage

Independent Standards and Spec reviews used remote issue-700, pinned at d56453d5541b879cd04a4f202aa2937dc14ba3d6. Fresh final-revision reviewers read all 11 changed files at 6c8d122, including the fixture fixes. Standards' initial P3 duplication finding was addressed; the final reviews found no further issues. Spec reported no findings. No changed file was left unread by either axis. No generated output was excluded.

Unaddressed findings

Standards

None.

Spec

None.

Merge Danger

Door: two-way

Blast Radius: observability

Adds version metadata and a locked cache beside the owning Command log. Failed version lookups record unknown and preserve the Session outcome.

Built with codex · gpt-6.1-sol · xhigh

@JacobStephens2
JacobStephens2 merged commit c70337e into issue-700 Oct 22, 2026
18 checks passed
@JacobStephens2
JacobStephens2 deleted the issue-986 branch October 22, 2026 04:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant