Repository navigation
Record Harness versions in Session trace resources - #1052
Merged
Merged
Conversation
This was referenced Oct 22, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Each Session trace records
thirdshift.harness.versionfor all six Harnesses.Closes #986
Evidence
cargo test --test session_traces all_six_harnesses_record_their_version_in_session_trace_resourcesfailed because Codex's resource had nothirdshift.harness.version.After: the regression passes for all six Harnesses;
cargo test --test session_tracespasses all 8 tests, including parallel Tickets, separate Commands, unknown versions, stream precedence and a separate Security review Harness.--versionas another Session, and log-list checks included the new cache artifacts.After: the fixtures answer version queries separately; all 10
cargo test --bin thirdshift session::execution_teststests and all 12cargo test --test command_logstests pass, preserving their behavior assertions.cargo checkpassed locally.cargo fmt --checkandcargo clippy --all-targets -- -D warningsalso passed in CI for final head6c8d122.scripts/affected-tests origin/issue-700rancargo nextest run: 2,280 passed, 3 skipped./usr/bin/time -p scripts/affected-tests origin/issue-700measured 2,313.88 s wall (build step included; cached build took 0.93 s). CI also passed for final head6c8d122.Test seams
thirdshiftCLI with real Git and fake Harness executables, observing Session trace resources and version-command invocations across Sessions and child Runs.Sessions::withinwith executable CLI fixtures, observing process cleanup, retained reporting, and prompt transport after execution failures.Review coverage
Independent Standards and Spec reviews used remote
issue-700, pinned atd56453d5541b879cd04a4f202aa2937dc14ba3d6. Fresh final-revision reviewers read all 11 changed files at6c8d122, including the fixture fixes. Standards' initial P3 duplication finding was addressed; the final reviews found no further issues. Spec reported no findings. No changed file was left unread by either axis. No generated output was excluded.Unaddressed findings
Standards
None.
Spec
None.
Merge Danger
Door: two-way
Blast Radius: observability
Adds version metadata and a locked cache beside the owning Command log. Failed version lookups record
unknownand preserve the Session outcome.Built with codex · gpt-6.1-sol · xhigh