You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
ensure thirdshift setup asks for a base fix setting #288
Setup currently asks about Base fixes only when every Run is a Merge run; otherwise it writes base.fix = false. This matches the earlier explicit #221/#223 contract. Base fixing itself can also be allowed for a Run that only delivers a ready-for-review PR, so the question's gate can hide a usable setting.
Decision needed: Ask about Base fixes regardless of the merge default, retaining the current configured answer as the default? If so, this is a small Setup change; update the old contract and cover both merge settings, including preserving an existing true value.
Category: enhancement Summary: Setup asks whether every Run may start a Base fix, whatever the Merge run answer
Current behavior: thirdshift setup asks "Every Run may start a Base fix when the Base branch's CI is red?" only when "Every Run a Merge run?" is answered yes. Otherwise it writes base.fix = false, which also replaces a true set by hand earlier. A Base fix helps a Run left ready for review too: instead of failing on an Inherited failure, the Run waits for the Base fix, merges the fixed Base branch in and watches CI again.
Desired behavior:
Setup always asks the Base fix question, right after the Merge run question, with the current base.fix as the default answer. The base.fix it writes is the answer given, whatever merge.always is.
Key interfaces:
Setup's questions and their answers (merge_always, base_fix), and the doc comments that describe the old gating.
The guide's Setup section, if it describes the gating.
Acceptance criteria:
With "Every Run a Merge run?" answered no, Setup asks the Base fix question, and answering yes writes base.fix = true.
With it answered yes, Setup behaves as today.
With an existing base.fix = true and the Merge run question answered no, pressing Enter at the Base fix question keeps base.fix = true.
Tests that pinned the old gating are updated to the new behavior.
Out of scope:
What a Base fix does, and its default with no User config (false).
Activity
JacobStephens2 commentedon Oct 17, 2026
Triage Notes
Setup currently asks about Base fixes only when every Run is a Merge run; otherwise it writes
base.fix = false. This matches the earlier explicit #221/#223 contract. Base fixing itself can also be allowed for a Run that only delivers a ready-for-review PR, so the question's gate can hide a usable setting.Decision needed: Ask about Base fixes regardless of the merge default, retaining the current configured answer as the default? If so, this is a small Setup change; update the old contract and cover both merge settings, including preserving an existing true value.
JacobStephens2 commentedon Oct 21, 2026
Agent Brief
Category: enhancement
Summary: Setup asks whether every Run may start a Base fix, whatever the Merge run answer
Current behavior:
thirdshift setupasks "Every Run may start a Base fix when the Base branch's CI is red?" only when "Every Run a Merge run?" is answered yes. Otherwise it writesbase.fix = false, which also replaces atrueset by hand earlier. A Base fix helps a Run left ready for review too: instead of failing on an Inherited failure, the Run waits for the Base fix, merges the fixed Base branch in and watches CI again.Desired behavior:
Setup always asks the Base fix question, right after the Merge run question, with the current
base.fixas the default answer. Thebase.fixit writes is the answer given, whatevermerge.alwaysis.Key interfaces:
merge_always,base_fix), and the doc comments that describe the old gating.Acceptance criteria:
base.fix = true.base.fix = trueand the Merge run question answered no, pressing Enter at the Base fix question keepsbase.fix = true.Out of scope:
false).