Releasing a Claim, and removing it when thirdshift closes the issue #281

Parent

#212

What to build

The two ways thirdshift takes a Claim off an issue.

Release. A Run that ends with nothing on origin to take over, no Issue branch and no pull request for the issue, puts the issue's labels back as they were before the Claim. For a Spec run, that is no Spec branch on origin and no Spec PR. So an outage, such as a usage limit or an expired login, costs a retry and doesn't strand the issue. Any other ending keeps the Claim: a pull request ready for review, or a Failed run that pushed work.

Removal on close. Where thirdshift itself closes the issue, after a Self-merge, it also removes in-progress. A failure to remove it is a warning: line, like the other steps after a merge, and doesn't change the outcome.

A process killed outright releases nothing; the Day shift relabels.

Acceptance criteria

• A Run whose session fails with no changes, so that nothing is pushed, ends with the issue labelled as it was before the Run: ready-for-agent back if it had it, and no in-progress.
• An issue that had no ready-for-agent before the Run doesn't gain it on release.
• An interrupted Run that left nothing on origin releases its Claim too.
• A Failed run that pushed its Issue branch keeps the Claim.
• A Run that ends with its pull request ready for review keeps the Claim.
• A Spec run that ends with no Spec branch on origin and no Spec PR releases the Spec's Claim; one with either keeps it.
• A Merge run ends with the issue closed and without in-progress.
• A Merge run of a Spec does the same for the Spec.
• When removing the label after a merge fails, the run still succeeds, with a warning: line naming the command to run by hand.
• The README says when a Claim is released, when it stays and when it is removed.
• End-to-end cases cover the above in the existing tests for Failed runs, Merge runs and Spec runs.

Blocked by

• The Claim: a Run or Spec run marks its issue in-progress #280